Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Fix web_programming directory #4297

Merged
merged 34 commits into from Mar 31, 2021
Merged

[mypy] Fix web_programming directory #4297

merged 34 commits into from Mar 31, 2021

Conversation

@cclauss
Copy link
Member

@cclauss cclauss commented Mar 28, 2021 •
edited

A subtask of #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
cclauss and others added 22 commits Mar 28, 2021
@cclauss
Experiment: monkeytype stub web_programming
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
2428a10
@cclauss
pytest --doctest-modules web_programming
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
1ef01e7
@cclauss
world_covid19_stats.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
aaea821
@cclauss
monkeytype stub web_programming.world_covid19_stats
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6b96969
@cclauss
Create monkeytype_config.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
2220b88
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
484855c
@cclauss
monkeytype run pytest --doctest-modules
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6570772
@cclauss
monkeytype run python3 -m pytest --doctest-modules
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
73712f1
@cclauss
Update monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
bb8909f
@cclauss
/opt/hostedtoolcache/Python/3.9.2/x64/bin/python3/opt/hostedtoolcache…
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5480ec4 
…/Python/3.9.2/x64/bin/python3/opt/hostedtoolcache/Python/3.9.2/x64/bin/python3
@cclauss
Update monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
ccf7acf
@cclauss
Update monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
2df9939
@cclauss
monkeytype run web_programming/*.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5ed45b3
@cclauss
monkeytype list-modules
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
7ab64b3
@cclauss
Update monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
b532d22
@cclauss
Update monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
7a14b85
@cclauss
Update monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
7090302
@cclauss
pyannotate
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
dcd5109
@cclauss
from pyannotate_runtime import collect_types
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
560de38
@cclauss
typing: API_KEY is a str
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3546524
@cclauss
pyannotate emails_from_url.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
da9ec61
@cclauss
pyannotate web_programming/emails_from_url.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
8cc34cd
@github-actions github-actions bot force-pushed the monkeytype-stub-web_programming branch from 78cf514 to 8cc34cd Mar 28, 2021
cclauss and others added 7 commits Mar 28, 2021
@cclauss
Update world_covid19_stats.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
d649a70
@cclauss
Delete monkeytype_config.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
5178056
github-actions github-actions
updating DIRECTORY.md
Loading status checks…
a2f7d42
@cclauss
Apply pyannotate suggestions to emails_from_url.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
3e6fcdc
@cclauss
mypy web_programming/emails_from_url.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
b36d324
@cclauss
super().__init__()
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
b3a99d8
@cclauss
mypy --ignore-missing-imports web_programming/emails_from_url.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
7c01695
cclauss added 4 commits Mar 28, 2021
@cclauss
Update emails_from_url.py
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
92caa16
@cclauss
self.urls: list[str] = []
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
aabeb4c
@cclauss
mypy: Fix web_programming directory
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
e3f3749
@cclauss
Delete monkeytype.yml
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
6d7fd3a
@cclauss cclauss requested a review from dhruvmanila Mar 28, 2021
@cclauss cclauss changed the title Experiment: monkeytype stub web_programming mypy: Fix web_programming directory Mar 28, 2021
@cclauss cclauss marked this pull request as ready for review Mar 28, 2021
@cclauss
Copy link
Member Author

@cclauss cclauss commented Mar 28, 2021 •
edited

Please Squash & merge to get rid of experimental commits.

I tried to use MonkeyType but it is impossible!! PyAnnotate is the way to go.
@cclauss cclauss changed the title mypy: Fix web_programming directory [mypy] Fix web_programming directory Mar 28, 2021
@dhruvmanila
Merge branch 'master' into monkeytype-stub-web_programming
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
648c047
@dhruvmanila
dhruvmanila approved these changes Mar 31, 2021
View changes
@dhruvmanila dhruvmanila merged commit 895bca3 into master Mar 31, 2021
5 checks passed
5 checks passed
@github-actions
build
Details
@github-actions
build
Details
@github-actions
pre-commit
Details
@github-actions
pre-commit
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@cclauss cclauss deleted the monkeytype-stub-web_programming branch Mar 31, 2021
peRFectBeliever added a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@cclauss github-actions
@dhruvmanila @peRFectBeliever
[mypy] Fix web_programming directory (TheAlgorithms#4297)
Loading status checks…
700820e 
* Update world_covid19_stats.py

* Delete monkeytype_config.py

* updating DIRECTORY.md

* Apply pyannotate suggestions to emails_from_url.py

* mypy web_programming/emails_from_url.py

* super().__init__()

* mypy --ignore-missing-imports web_programming/emails_from_url.py

* Update emails_from_url.py

* self.urls: list[str] = []

* mypy: Fix web_programming directory

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@cclauss github-actions @dhruvmanila
[mypy] Fix web_programming directory (TheAlgorithms#4297)
cd81f1b 
* Update world_covid19_stats.py

* Delete monkeytype_config.py

* updating DIRECTORY.md

* Apply pyannotate suggestions to emails_from_url.py

* mypy web_programming/emails_from_url.py

* super().__init__()

* mypy --ignore-missing-imports web_programming/emails_from_url.py

* Update emails_from_url.py

* self.urls: list[str] = []

* mypy: Fix web_programming directory

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Co-authored-by: Dhruv Manilawala <dhruvmanila@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@cclauss @dhruvmanila