Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "redefinition" of dict element in problem 74 on project_euler #4309

Merged
merged 1 commit into from Apr 4, 2021
Merged

Remove "redefinition" of dict element in problem 74 on project_euler #4309

merged 1 commit into from Apr 4, 2021

Conversation

@donno2048
Copy link
Contributor

@donno2048 donno2048 commented Apr 3, 2021

Describe your change:

Unneccecery line removed

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@donno2048
Remove "redefinition" of dict element
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
19ff5d4
@donno2048 donno2048 requested review from dhruvmanila and Kush1101 as code owners Apr 3, 2021
@algorithms-keeper algorithms-keeper bot mentioned this pull request Apr 3, 2021
Closed
11 of 11 tasks complete
@dhruvmanila
dhruvmanila approved these changes Apr 4, 2021
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thanks for noticing that and fixing it!
@dhruvmanila dhruvmanila merged commit e7e6cbf into TheAlgorithms:master Apr 4, 2021
4 checks passed
4 checks passed
@github-actions
project-euler
Details
@github-actions
build
Details
@github-actions
pre-commit
Details
@github-actions
validate-solutions
Details
@donno2048 donno2048 deleted the donno2048:patch-3 branch Apr 4, 2021
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@donno2048
refactor: Remove "redefinition" of dict element (TheAlgorithms#4309)
3c249d0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

@Kush1101 Kush1101

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@donno2048 @dhruvmanila