Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check on Task, Task<IResult>, ValueTask, ValueTask<IResult> #33079

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@wcontayon
Copy link
Contributor

@wcontayon wcontayon commented May 27, 2021

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

PR Title
Add null check on Task, Task, ValueTask, ValueTask

PR Description
Prevent returning null from Map{Verb}(string, Delegate), adding a null check (that throw an exception) on Task, Task<IResult>, ValueTask, ValueTask<IResult>

https://github.com/wcontayon/AspNetCore/blob/cae7c582b6aec95c780897c089cc6d3e936842d7/src/Http/Http.Extensions/src/RequestDelegateFactory.cs#L830-L852

Addresses #32865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant