Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material-experimental/mdc-slider): initialize the aria-valuetext … #22877

Merged
merged 3 commits into from Jun 10, 2021

Conversation

Copy link
Contributor

@wagnermaciel wagnermaciel commented Jun 3, 2021

…for slider thumb inputs

  • The MDC Foundation does not set the aria-valuetext of slider inputs
    until a value change, so we need to manually initialize it.

…for slider thumb inputs

* The MDC Foundation does not set the aria-valuetext of slider inputs
  until a value change, so we need to manually initialize it.
@wagnermaciel wagnermaciel requested a review from crisbeto Jun 3, 2021
@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@wagnermaciel wagnermaciel marked this pull request as ready for review Jun 3, 2021
Copy link
Member

@crisbeto crisbeto left a comment

LGTM

src/material-experimental/mdc-slider/slider.ts Outdated Show resolved Hide resolved
@wagnermaciel wagnermaciel added merge ready target: patch labels Jun 4, 2021
Co-authored-by: Paul Gschwendtner <paulgschwendtner@gmail.com>
@wagnermaciel wagnermaciel added target: minor and removed target: patch labels Jun 10, 2021
@wagnermaciel wagnermaciel merged commit d5a5de2 into angular:master Jun 10, 2021
16 checks passed
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Jul 11, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes merge ready target: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants