Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows #26502

Merged
merged 1 commit into from Jun 3, 2021
Merged

bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows #26502

merged 1 commit into from Jun 3, 2021

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 3, 2021 •
edited by bedevere-bot

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.

https://bugs.python.org/issue43921

@vstinner
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows
1b6ec25 
Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
@vstinner vstinner requested a review from tiran as a code owner Jun 3, 2021
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 3, 2021
@vstinner
Copy link
Member Author

vstinner commented Jun 3, 2021

See #26501 (comment) for my debug notes on this issue.

@vstinner
Copy link
Member Author

vstinner commented Jun 3, 2021

cc @tiran @pablogsal: a PR fixing test_wrong_cert_tls13() similar to (but different than) my previous PR #26489 fixing test_pha_required_nocert().

@vstinner vstinner mentioned this pull request Jun 3, 2021
Closed
@vstinner vstinner merged commit ea0210f into python:main Jun 3, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 3, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@vstinner vstinner deleted the test_ssl2 branch Jun 3, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jun 3, 2021

Sorry @vstinner, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ea0210fa8ccca769896847f25fc6fadfe9a717bc 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Jun 3, 2021

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 3, 2021

GH-26518 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2021
@vstinner @miss-islington
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (pythonGH-…
9284d4b 
…26502)

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull request Jun 3, 2021
@miss-islington @vstinner
bpo-43921: Fix test_ssl.test_wrong_cert_tls13() on Windows (GH-26502) (…
d2ab15f 
…GH-26518)

Fix test_ssl.test_wrong_cert_tls13(): use suppress_ragged_eofs=False,
since read() can raise ssl.SSLEOFError on Windows.
(cherry picked from commit ea0210f)

Co-authored-by: Victor Stinner <vstinner@python.org>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees

@vstinner vstinner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @miss-islington @bedevere-bot @the-knights-who-say-ni