Skip to content

/ vue-jest

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup GitHub Actions #278

Open
wants to merge 6 commits into
base: master
from
Open

ci: setup GitHub Actions #278

wants to merge 6 commits into from

Conversation

@nogic1008
Copy link
Contributor

@nogic1008 nogic1008 commented Sep 11, 2020 •
edited

Note: To take advantage of this PR, you need to enable GitHub Actions on this repository.
sample jobs

  • Setup GitHub Actions workflow
    • Node.js 10, 12, 14
    • Jest 24, 25, 26
  • bump @babel/core and @babel/preset-env to 7.9.0 to fix error in Node.js 12 or above
nogic1008 added 6 commits Sep 11, 2020
@nogic1008
ci: enable GitHub Actions
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cf7a2f9
@nogic1008
refactor: rename
6cfb77d
@nogic1008
chore(deps-dev): bump @babel/core to 7.9.0
3d700b2
@nogic1008
ci: matrix jest version
70e1dd6
@nogic1008
test: separate jest install process
Loading status checks…
8e3cc49
@nogic1008
Merge remote-tracking branch 'upstream/master' into ci/github-actions
Loading status checks…
7190a0f
@lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Sep 17, 2020

Interesting. Is there an advantage to GH actions over Circle CI for example?
@nogic1008
Copy link
Contributor Author

@nogic1008 nogic1008 commented Sep 18, 2020

@lmiller1990

Advantage:

  • Circle CI cannot watch test results without signing up, but GitHub Actions can do.
  • Circle CI can also use matrix jobs, but free plan don't run in parallel. It will take more time.
  • Testing can be done even in forked repositories. (need to opt in there)
  • Lots of reusable actions (like orb in Circle CI) are available in the community.

Disadvantage:

  • GitHub Actions cannot rerun job partially. only can "Rerun All".
  • It is difficult to access the running job with SSH etc.
@lmiller1990
Copy link
Member

@lmiller1990 lmiller1990 commented Sep 18, 2020

Sounds like we should ues GH actions. I will look into this on the weekend. Thanks!
@nogic1008
Copy link
Contributor Author

@nogic1008 nogic1008 commented Sep 18, 2020

@lmiller1990
Thank you for your interest.
This PR conflicts with #284, so I'll rebase it after 284 has been merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nogic1008 @lmiller1990
You can’t perform that action at this time.