Skip to content

Remove ci/no-build #59889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove ci/no-build #59889

wants to merge 1 commit into from

Conversation

samestep
Copy link
Contributor

This reverts #58778, since triggering our primary CircleCI workflow only via pytorch-probot has been causing more problems than it's worth.

@samestep samestep requested a review from a team June 11, 2021 18:48
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 11, 2021 •
edited
Loading

💊 CI failures summary and remediations

As of commit 59341ae (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot
Copy link
Contributor

@samestep has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@samestep samestep mentioned this pull request Jun 11, 2021
Closed
@facebook-github-bot
Copy link
Contributor

@samestep merged this pull request in a9e136a.

@seemethere seemethere mentioned this pull request Jun 11, 2021
Closed
@samestep samestep mentioned this pull request Jun 14, 2021
Closed
facebook-github-bot pushed a commit that referenced this pull request Jun 15, 2021
@samestep @facebook-github-bot
Don't run_build when run_binary_tests (#59982)
1c502d1 
Summary:
#59889 wasn't a proper revert of #58778. This PR fixes that.

Pull Request resolved: #59982

Reviewed By: seemethere

Differential Revision: D29114129

Pulled By: samestep

fbshipit-source-id: b40563db6ff1153a5f759639978279f5fcbccaa9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@walterddr walterddr walterddr approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samestep @facebook-github-bot @seemethere @walterddr @janeyx99