Skip to content

bpo-44283: Add jump table for match-cases of None, int, and str constants, as well as or-patterns of these. #26697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 30 commits into from
Closed

bpo-44283: Add jump table for match-cases of None, int, and str constants, as well as or-patterns of these. #26697

wants to merge 30 commits into from

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Jun 12, 2021 •
edited by bedevere-bot
Loading

brandtbucher and others added 24 commits June 4, 2021 10:56
@brandtbucher
Make dicts hashable (for now).
3cb2dcc
@brandtbucher
Add scaffolding for jump tables in the compiler/assembler.
bdf1fcb
@brandtbucher
Clarify the implementation a bit.
c1f4882
@sweeneyde
Implement ATTEMPT_SAFE_MATCH
cba6068
@sweeneyde
Get the simplest all-constants case working
e84fdd9
@sweeneyde
make test_patma pass
62321b7
@sweeneyde
Fix refleak
91582f4
@sweeneyde
Add test cases that jump tables exist
b25665e
@sweeneyde
Make simple-followed-by-nonsimple work
d4b0d19
@sweeneyde
test cases for deoptimized case
d6cb25a
@sweeneyde
variable name 'x' --> 'subject'
0660406
@sweeneyde
Get test cases 1-173 passing
663734e
@sweeneyde
Get all the tests passing
113bed8
@sweeneyde
Add more tests
3774985
@sweeneyde
Remove unnecessary jump
1f1bc65
@sweeneyde
Allow for simple OR-patterns
77b4239
@sweeneyde
Add or pattern test cases
8ef92ed
@sweeneyde
Remove debugging code
ad61a9b
@sweeneyde
tests for nested OR patterns
4216e76
@sweeneyde
Implement jump_table type
338196e
@sweeneyde
Revert "Make dicts hashable (for now)."
ab4dba7 
This reverts commit 3cb2dcc.
@sweeneyde
Fix refleak
1791b8d
@sweeneyde
Include jump table files
c8a2a6f
@sweeneyde
PEP 7 braces
3b31ed8
@sweeneyde sweeneyde marked this pull request as ready for review June 12, 2021 21:52
@sweeneyde sweeneyde requested review from markshannon, tiran and a team as code owners June 12, 2021 21:52
@brandtbucher brandtbucher self-requested a review June 17, 2021 16:55
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jul 18, 2021
MaxwellDupre
MaxwellDupre approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my machine, unfortunately cant check on windoz.

MaxwellDupre
MaxwellDupre approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 9, 2022
brandtbucher
brandtbucher requested changes Apr 25, 2023
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a cool experiment, but I think it's too big of a change right now (especially considering PEP 669 was just implemented, which doesn't support multi-way branches). Plus, most of the bytecode compiler and interpreter have been refactored since this change was implemented.

I suggest we close this. Thoughts, @sweeneyde? We could always refer to it if we decide this is worth doing in the future.

@sweeneyde
Copy link
Member Author

Sounds good to me. It is a little fishy to only work on literals anyway.

@sweeneyde sweeneyde closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher requested changes

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sweeneyde @MaxwellDupre @brandtbucher @the-knights-who-say-ni @ezio-melotti @bedevere-bot