Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44362: ssl: improve deprecation warnings and docs (GH-26646) #26646

Merged
merged 1 commit into from Jun 11, 2021
Merged

bpo-44362: ssl: improve deprecation warnings and docs (GH-26646) #26646

merged 1 commit into from Jun 11, 2021

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jun 10, 2021 •
edited by bedevere-bot

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue44362
graingert
graingert reviewed Jun 10, 2021
View changes
Modules/_ssl.c Outdated
@@ -3583,7 +3593,7 @@ set_options(PySSLContext *self, PyObject *arg, void *c)
set = ~opts & new_opts;

if ((set & opt_no) != 0) {
if (_ssl_deprecated("Setting OP_NO_SSL* or SSL_NO_TLS* options is "
if (_ssl_deprecated("Setting OP_NO_SSL*/ssl.SSL_NO_TLS* options is "
Copy link
Contributor

@graingert graingert Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (_ssl_deprecated("Setting OP_NO_SSL*/ssl.SSL_NO_TLS* options is "
if (_ssl_deprecated("Setting ssl.OP_NO_SSL*/ssl.SSL_NO_TLS* options is "

graingert
graingert reviewed Jun 10, 2021
View changes
Modules/_ssl.c Outdated Show resolved Hide resolved
@graingert graingert mentioned this pull request Jun 10, 2021
Closed
@tiran
bpo-44362: ssl: improve deprecation warnings and docs
24096d7 
Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran force-pushed the bpo-44362-ssl-depr branch from f656ee3 to 24096d7 Jun 10, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 10, 2021

🤖 New build scheduled with the buildbot fleet by @tiran for commit 24096d7 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@tiran tiran changed the title bpo-44362: ssl: improve deprecation warnings and docs bpo-44362: ssl: improve deprecation warnings and docs (GH-26646) Jun 11, 2021
@tiran tiran merged commit e26014f into python:main Jun 11, 2021
77 checks passed
@tiran tiran deleted the bpo-44362-ssl-depr branch Jun 11, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 11, 2021

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jun 11, 2021
@tiran @miss-islington
bpo-44362: ssl: improve deprecation warnings and docs (pythonGH-26646)
d00dd3e 
Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit e26014f)

Co-authored-by: Christian Heimes <christian@python.org>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 11, 2021

GH-26665 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit that referenced this issue Jun 11, 2021
@tiran @miss-islington
bpo-44362: ssl: improve deprecation warnings and docs (GH-26646)
d7930fb 
Signed-off-by: Christian Heimes <christian@python.org>
(cherry picked from commit e26014f)

Co-authored-by: Christian Heimes <christian@python.org>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@tiran @JuniorJPDJ
bpo-44362: ssl: improve deprecation warnings and docs (pythonGH-26646)
06cc4fc 
Signed-off-by: Christian Heimes <christian@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graingert graingert

Assignees
No one assigned
Labels
CLA signed type-documentation
Projects
None yet
Milestone
No milestone
5 participants
@tiran @bedevere-bot @miss-islington @graingert @the-knights-who-say-ni