Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-39481: PEP 585 for a variety of modules #19423

Merged
merged 3 commits into from Apr 10, 2020
Merged

bpo-39481: PEP 585 for a variety of modules #19423

merged 3 commits into from Apr 10, 2020

Conversation

isidentical
Copy link
Sponsor Member

@isidentical isidentical commented Apr 7, 2020 •
edited by bedevere-bot

  • queue.SimpleQueue
  • queue.Queue
  • tempfile.TemporaryDirectory
  • unittest.case._AssertRaisesContext

https://bugs.python.org/issue39481

@isidentical isidentical requested a review from rhettinger as a code owner Apr 7, 2020
@isidentical isidentical requested a review from gvanrossum Apr 7, 2020
ethanhs
ethanhs reviewed Apr 8, 2020
View changes
Lib/test/test_genericalias.py Outdated Show resolved Hide resolved
gvanrossum
gvanrossum approved these changes Apr 10, 2020
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Once your other PR (#19418) lands you will have to rebase; then ping me and I'll land it.

Lib/test/test_genericalias.py Outdated Show resolved Hide resolved
@gvanrossum gvanrossum changed the title bpo-39481: Generic Alias for SimpleQueue, Queue, TemporaryDirectory... bpo-39481: PEP 585 for queue, tempfile, unittest Apr 10, 2020
@gvanrossum gvanrossum closed this Apr 10, 2020
@gvanrossum gvanrossum reopened this Apr 10, 2020
This was referenced Apr 10, 2020
Closed
Closed
@isidentical
Copy link
Sponsor Member Author

isidentical commented Apr 10, 2020

For preventing future conflicts, appending group2 and 3s into this PR.

@isidentical isidentical requested a review from tiran as a code owner Apr 10, 2020
@isidentical isidentical requested a review from gvanrossum Apr 10, 2020
@gvanrossum gvanrossum changed the title bpo-39481: PEP 585 for queue, tempfile, unittest bpo-39481: PEP 585 for a variety of modules Apr 10, 2020
@gvanrossum gvanrossum merged commit 0361556 into python:master Apr 10, 2020
@cdce8p cdce8p mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanhs ethanhs

@gvanrossum gvanrossum

@rhettinger rhettinger

@tiran tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@isidentical @gvanrossum @ethanhs @the-knights-who-say-ni @bedevere-bot