Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44211: Remove duplicate mime type mapping .bmp -> image/x-ms-bmp #26300

Merged
merged 1 commit into from May 29, 2021
Merged

bpo-44211: Remove duplicate mime type mapping .bmp -> image/x-ms-bmp #26300

merged 1 commit into from May 29, 2021

Conversation

andreasjansson
Copy link
Contributor

@andreasjansson andreasjansson commented May 21, 2021 •
edited by bedevere-bot

@andreasjansson andreasjansson requested a review from a team as a code owner May 21, 2021
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented May 21, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@andreasjansson

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

nanjekyejoannah
nanjekyejoannah reviewed May 27, 2021
View changes
Copy link
Member

@nanjekyejoannah nanjekyejoannah left a comment

The change sounds reasonable to me, but am not sure I can merge a PR without the author signing the CLA.

@andreasjansson
Copy link
Contributor Author

andreasjansson commented May 28, 2021 •
edited

@nanjekyejoannah I signed the CLA and the check-python-cla app says it's gone through

Is there some step that I'm missing?

Nevermind it just came through :)

@nanjekyejoannah nanjekyejoannah merged commit de14d70 into python:main May 29, 2021
12 checks passed
@akulakov akulakov mentioned this pull request Sep 8, 2021
Closed
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2021

Thanks @andreasjansson for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2021

Thanks @andreasjansson for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2021

GH-28284 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

bedevere-bot commented Sep 11, 2021

GH-28285 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2021
@andreasjansson @miss-islington
Remove duplicate mime type mapping .bmp -> image/x-ms-bmp (pythonGH-2…
2dbdc32 
…6300)

Thanks for the contribution @andreasjansson
(cherry picked from commit de14d70)

Co-authored-by: Andreas Jansson <andreas.s.t.jansson@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2021
@andreasjansson @miss-islington
Remove duplicate mime type mapping .bmp -> image/x-ms-bmp (pythonGH-2…
48a298f 
…6300)

Thanks for the contribution @andreasjansson
(cherry picked from commit de14d70)

Co-authored-by: Andreas Jansson <andreas.s.t.jansson@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2021

Thanks @andreasjansson for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Sep 11, 2021

Thanks @andreasjansson for the PR, and @nanjekyejoannah for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah

@python/email-team email-team

Assignees
No one assigned
Labels
skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andreasjansson @the-knights-who-say-ni @miss-islington @bedevere-bot @nanjekyejoannah @serhiy-storchaka