bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595

markshannon · 2021-06-08T10:26:03Z

Implements four specializations of LOAD_ATTR:

LOAD_ATTR_SLOT for slots.
LOAD_ATTR_SPLIT_KEYS for attributes in instance dictionaries that have split keys.
LOAD_ATTR_HINT for attributes in instance dictionaries that do not have split keys.
LOAD_ATTR_MODULE for module attributes

There are more specializations of LOAD_ATTR that we want to implement, but this PR is large enough already.

https://bugs.python.org/issue44337

… in dictionary when specializing.

bedevere-bot · 2021-06-08T12:54:44Z

🤖 New build scheduled with the buildbot fleet by @markshannon for commit f9e999c 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

bedevere-bot · 2021-06-09T12:49:20Z

🤖 New build scheduled with the buildbot fleet by @markshannon for commit b07f219 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

bedevere-bot · 2021-06-09T14:49:33Z

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 6d9ef8d 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

pablogsal · 2021-06-09T16:38:53Z

@markshannon You may want to check out https://bugs.python.org/msg395432 . This shows that the ASAN failures are not false positives as there is obviously something corrupted and we are reading that memory.

markshannon · 2021-06-09T17:27:50Z

Hopefully #26626 will fix the address sanitizer failures

bedevere-bot · 2021-06-09T23:52:26Z

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 41cb98f 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

markshannon added 11 commits May 26, 2021

Specialize LOAD_ATTR with LOAD_ATTR_SLOT and LOAD_ATTR_SPLIT_KEYS

8db0653

Move dict-common.h to internal/pycore_dict.h

35522bc

Add LOAD_ATTR_COMBINED_KEYS specialized opcode.

3ca2c7c

Quicken in function if loopy

3d50df3

Specialize LOAD_ATTR for module attributes.

85dd177

Set dict version to zero before setting index

e54f76b

Don't crash if module has no dictionary

eb08f91

Rename LOAD_ATTR_COMBINED_KEYS to LOAD_ATTR_WITH_HINT. Add NEWS item.

a03abb3

Fix name and use wider cache slot.

1079964

Remove rebase artifact

d2e0940

Use specialization stats

d890943

markshannon requested a review from methane as a code owner Jun 8, 2021

the-knights-who-say-ni added the CLA signed label Jun 8, 2021

bedevere-bot added the awaiting core review label Jun 8, 2021

Use _PyDict_GetItemHint instead of _Py_dict_lookup to determine index…

f9e999c

… in dictionary when specializing.

markshannon added the 🔨 test-with-buildbots label Jun 8, 2021

bedevere-bot removed the 🔨 test-with-buildbots label Jun 8, 2021

methane approved these changes Jun 9, 2021

View changes

bedevere-bot added awaiting merge and removed awaiting core review labels Jun 9, 2021

markshannon added 3 commits Jun 9, 2021

Assert that address is in bounds (ASAN thinks it might not be).

e858ea1

Fix off by one error

a0ed9e2

Fix compiler warnings and check slot offset can be stored in index field

b07f219

markshannon added the 🔨 test-with-buildbots label Jun 9, 2021

bedevere-bot removed the 🔨 test-with-buildbots label Jun 9, 2021

Merge branch 'main' into specialize-load-attr

6d9ef8d

markshannon added the 🔨 test-with-buildbots label Jun 9, 2021

bedevere-bot removed the 🔨 test-with-buildbots label Jun 9, 2021

markshannon closed this Jun 9, 2021

markshannon reopened this Jun 9, 2021

markshannon closed this Jun 9, 2021

Merge branch 'main' into specialize-load-attr

41cb98f

markshannon reopened this Jun 9, 2021

markshannon added the 🔨 test-with-buildbots label Jun 9, 2021

bedevere-bot removed the 🔨 test-with-buildbots label Jun 9, 2021

bedevere-bot removed the awaiting merge label Jun 10, 2021

markshannon deleted the faster-cpython:specialize-load-attr branch Jun 10, 2021

python / cpython

bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595

bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595

markshannon commented Jun 8, 2021 •

edited by bedevere-bot

bedevere-bot commented Jun 8, 2021

bedevere-bot commented Jun 9, 2021

bedevere-bot commented Jun 9, 2021

pablogsal commented Jun 9, 2021 •

edited

markshannon commented Jun 9, 2021

bedevere-bot commented Jun 9, 2021

python / cpython

Sponsor python/cpython

bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595

bpo-44337: Port LOAD_ATTR to PEP 659 adaptive interpreter #26595

Conversation

markshannon commented Jun 8, 2021 • edited by bedevere-bot

bedevere-bot commented Jun 8, 2021

bedevere-bot commented Jun 9, 2021

bedevere-bot commented Jun 9, 2021

pablogsal commented Jun 9, 2021 • edited

markshannon commented Jun 9, 2021

bedevere-bot commented Jun 9, 2021

markshannon commented Jun 8, 2021 •

edited by bedevere-bot

pablogsal commented Jun 9, 2021 •

edited