Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-43693: Un-revert commit f3fa63e. #26609

Merged

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 8, 2021

This was reverted in GH-26596 (commit 6d518bb) due to some bad memory accesses.

The memory accesses have been fixed and I verified the address sanitizer is happy now (after duplicating the failure locally).

https://bugs.python.org/issue43693

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 8, 2021

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5107da7 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 8, 2021

Thanks for the quick fix, @ericsnowcurrently

@ericsnowcurrently ericsnowcurrently removed the request for review from markshannon Jun 8, 2021
@ericsnowcurrently ericsnowcurrently merged commit 3e1c716 into python:main Jun 8, 2021
48 of 59 checks passed
48 of 59 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@bedevere-bot
buildbot/AMD64 RHEL8 Refleaks PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable LTO + PGO PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable LTO PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 LTO PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 PR Build started.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 Refleaks PR Build started.
Details
@bedevere-bot
buildbot/s390x Fedora Clang Installed PR Build started.
Details
@bedevere-bot
buildbot/s390x Fedora Clang PR Build started.
Details
@bedevere-bot
buildbot/s390x Fedora LTO + PGO PR Build started.
Details
@bedevere-bot
buildbot/s390x Fedora LTO PR Build started.
Details
Azure Pipelines PR #20210608.35 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 43693 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@bedevere-bot
buildbot/AMD64 Debian PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Debian root PR Build done.
Details
@bedevere-bot
buildbot/AMD64 FreeBSD Non-Debug PR Build done.
Details
@bedevere-bot
buildbot/AMD64 FreeBSD Shared PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL7 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 LTO PR Build done.
Details
@bedevere-bot
buildbot/AMD64 RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Ubuntu Shared PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 PR Build done.
Details
@bedevere-bot
buildbot/AMD64 Windows10 Pro PR Build done.
Details
@bedevere-bot
buildbot/PPC64 Fedora PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable Clang Installed PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE Fedora Stable Clang PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL7 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/PPC64LE RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x Debian PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 LTO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL7 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 LTO + PGO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 LTO PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 PR Build done.
Details
@bedevere-bot
buildbot/s390x RHEL8 Refleaks PR Build done.
Details
@bedevere-bot
buildbot/s390x SLES PR Build done.
Details
@bedevere-bot
buildbot/x86 Gentoo Installed with X PR Build done.
Details
@bedevere-bot
buildbot/x86 Gentoo Non-Debug with X PR Build done.
Details
@bedevere-bot
buildbot/x86-64 macOS PR Build done.
Details
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 8, 2021

@ericsnowcurrently: Please replace # with GH- in the commit message next time. Thanks!

@ericsnowcurrently ericsnowcurrently deleted the ericsnowcurrently:unrevert-add-make-cell branch Jun 8, 2021
ericsnowcurrently added a commit that referenced this pull request Jun 9, 2021
This is the same fix as for PyFrame_LocalsToFast() in gh-26609, but applied to PyFrame_FastToLocalsWithError(). (It should have been in that PR.)

https://bugs.python.org/issue43693
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants