Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Crosslinking to Gitpod guide #19185

Merged
merged 5 commits into from Jun 10, 2021
Merged

DOC: Crosslinking to Gitpod guide #19185

merged 5 commits into from Jun 10, 2021

Conversation

@MarsBarLee
Copy link
Contributor

@MarsBarLee MarsBarLee commented Jun 7, 2021

A very helpful page, Using Gitpod for NumPy Development, was not crosslinked in two other pages about building NumPy. The two pages are 'Building from source' and 'Building the NumPy API and reference docs'.

Please let me know if the added wording about building the source is technically correct.

I also had a commit hiccup. I modified my commit messages after pushing (using rebase and --force-with-lease), and it looks like this also brought @Mukulikaa recent commits with this PR. It looks we pushed our commits around the same time but from our own forks and branches. We worked on different pages, her on 'absolute-beginners.html' and mine are 'howto_build_docs.rst' and 'building.rst'.

However, her most recent commit was also on building.rst, but those changes are not in this commit.

I'm not sure how to detangle that, so would appreciate any help. :)

@charris
Copy link
Member

@charris charris commented Jun 7, 2021

Looks like your editor is set up to wrap lines instead of breaking them. We try to keep line length < 80 characters with hard line breaks.

@MarsBarLee MarsBarLee force-pushed the MarsBarLee:crosslink-gitpod branch from 703d66a to 9964bf8 Jun 8, 2021
@MarsBarLee
Copy link
Contributor Author

@MarsBarLee MarsBarLee commented Jun 8, 2021

@charris Thanks for the information! I'm using Gitpod, so I've added automatic word wrapping. I've fixed the tangled commits with Melissa's help and added the line breaks.

@charris charris merged commit dae36b3 into numpy:main Jun 10, 2021
36 checks passed
36 checks passed
@github-actions
lint
Details
@github-actions
pr-labeler
Details
@github-actions
smoke_test
Details
@github-actions
basic (3.8)
Details
@github-actions
basic (3.9)
Details
@github-actions
debug
Details
@github-actions
blas64
Details
@github-actions
full
Details
@github-actions
benchmark
Details
@github-actions
no_relaxed_strides
Details
@github-actions
use_wheel
Details
@github-actions
no_array_func
Details
@github-actions
no_openblas
Details
@github-actions
pypy37
Details
@github-actions
sdist
Details
@lgtm-com
LGTM analysis: C/C++ No code changes detected
Details
@lgtm-com
LGTM analysis: JavaScript No code changes detected
Details
@lgtm-com
LGTM analysis: Python No code changes detected
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@azure-pipelines
azure-pipeline numpy.numpy Build #20210610.18 succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Linux_Python_38_32bit_full_with_asserts) ComprehensiveTests Linux_Python_38_32bit_full_with_asserts succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Linux_gcc48) ComprehensiveTests Linux_gcc48 succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Windows Python37-64bit-full) ComprehensiveTests Windows Python37-64bit-full succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Windows Python38-32bit-fast) ComprehensiveTests Windows Python38-32bit-fast succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Windows Python38-64bit-full) ComprehensiveTests Windows Python38-64bit-full succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Windows Python39-32bit-fast) ComprehensiveTests Windows Python39-32bit-fast succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests Windows Python39-64bit-full) ComprehensiveTests Windows Python39-64bit-full succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests WindowsFast Python37-32bit-fast) ComprehensiveTests WindowsFast Python37-32bit-fast succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests macOS Python37) ComprehensiveTests macOS Python37 succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (ComprehensiveTests macOS Python37-ILP64) ComprehensiveTests macOS Python37-ILP64 succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (InitialTests Lint) InitialTests Lint succeeded
Details
@azure-pipelines
azure-pipeline numpy.numpy (InitialTests Linux_baseline_native) InitialTests Linux_baseline_native succeeded
Details
ci/circleci: build Your tests passed on CircleCI!
Details
@github-actions
ci/circleci: build artifact Link to 0/doc/build/html/index.html
Details
@codecov
codecov/patch Coverage not affected when comparing 683a37a...0fcd62d
Details
@codecov
codecov/project 85.04% (+1.70%) compared to 683a37a
Details
@charris
Copy link
Member

@charris charris commented Jun 10, 2021

Thanks @MarsBarLee .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants