Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. #26577

Merged
merged 2 commits into from Jun 7, 2021
Merged

bpo-43693: Un-revert commits 2c1e258 and b2bf2bc. #26577

merged 2 commits into from Jun 7, 2021
+6,041 −5,707

Conversation

@ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jun 7, 2021 •
edited by bedevere-bot

These were reverted in gh-26530 (commit 17c4edc) due to refleaks.

  • 2c1e258 - Compute deref offsets in compiler (gh-25152)
  • b2bf2bc - Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (gh-26388)

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

https://bugs.python.org/issue43693
@ericsnowcurrently ericsnowcurrently removed the request for review from tiran Jun 7, 2021
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 7, 2021

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 4eb1135 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.
@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 7, 2021

This PR fixes the refleaks. (@pablogsal, I'm running it through the buildbots before merging this time.)

Thanks a lot @ericsnowcurrently ❤️
@ericsnowcurrently
Un-revert commits 2c1e258 and b2bf2bc.
5e98b69 
These were reverted in GH-26530 (commit 17c4edc).

* Compute deref offsets in compiler (gh-25152)
* Add new internal code objects fields: co_fastlocalnames and co_fastlocalkinds. (gh-26388)
@ericsnowcurrently
Fix refleaks.
1fb813c
@ericsnowcurrently ericsnowcurrently force-pushed the ericsnowcurrently:unrevert-localsplusnames branch from 4eb1135 to 1fb813c Jun 7, 2021
@ericsnowcurrently
Copy link
Member Author

@ericsnowcurrently ericsnowcurrently commented Jun 7, 2021

The buildbots say "the refleaks have been fixed". 🙂
@ericsnowcurrently ericsnowcurrently merged commit 2ab27c4 into python:main Jun 7, 2021
11 of 12 checks passed
11 of 12 checks passed
@github-actions
Docs
Details
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
Azure Pipelines PR in progress
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 43693 found
Details
@bedevere-bot
bedevere/news News entry found in Misc/NEWS.d
@ericsnowcurrently ericsnowcurrently deleted the ericsnowcurrently:unrevert-localsplusnames branch Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
4 participants
@ericsnowcurrently @bedevere-bot @pablogsal @the-knights-who-say-ni