Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finer custom fields match #792

Open
wants to merge 18 commits into
base: dev
from
Open

Finer custom fields match #792

wants to merge 18 commits into from

Conversation

@bloatware
Copy link
Member

@bloatware bloatware commented Oct 3, 2016

With pgonly="1" <txp:article_custom /> will output the number of matching articles pages, without setting the pagination.

bloatware added 2 commits Oct 3, 2016
With pgonly="1" <txp:article_custom /> will output the number of matching articles pages, without setting the pagination.
@makss
Copy link
Member

@makss makss commented Oct 3, 2016

It seems already been attempts to add pgonly attribute to article_custom tag.

@bloatware
Copy link
Member Author

@bloatware bloatware commented Oct 3, 2016

It seems already been attempts to add pgonly attribute to article_custom tag.

Sure, including mine, few years ago :-) It didn't get much attention, but I'm not desperate. The aim is to be able to easily count pages or articles (with pageby="1") for informational purposes or for use in pagination plugins.

@bloatware bloatware mentioned this pull request Nov 11, 2016
@bloatware bloatware changed the title Enable pageby and pgonly for <txp:article_custom /> tag Finer custom fields match Nov 12, 2016
@bloatware
Copy link
Member Author

@bloatware bloatware commented Nov 12, 2016

The initial patch (enable pages count for article_custom) is merged into dev now. The rest of this branch allows for finer custom fields match in article(_custom) and related_articles.

@Bloke
Copy link
Member

@Bloke Bloke commented Dec 28, 2016

Although I haven't tested it, this seems like a pretty good idea to me. Is it okay to be merged? Any backwards-compatibility issues?

Regarding the item attribute: it assumes comma is the separator. But an earlier commit references pipe also. Should we introduce a separator attribute here, like there is for the if_custom_field tag, so that people are free to delimit their custom fields in any way they see fit? Or is that too confusing?

@bloatware
Copy link
Member Author

@bloatware bloatware commented Dec 28, 2016

Thanks @Bloke. I thought we should postpone it to the unlimited custom fields era, also because separator could then become part of custom field definition.

@bloatware bloatware added this to the v4.8 milestone Jan 19, 2017
bloatware added 4 commits Feb 4, 2017
@petecooper petecooper modified the milestones: v4.8, v4.9 Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.