Skip to content

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Add/fix type annotations for boolean_algebra #4172

Merged
merged 3 commits into from Feb 4, 2021
Merged

[mypy] Add/fix type annotations for boolean_algebra #4172

merged 3 commits into from Feb 4, 2021

Conversation

@CodeHermyt
Copy link
Contributor

@CodeHermyt CodeHermyt commented Feb 2, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
CodeHermyt added 2 commits Feb 2, 2021
@CodeHermyt
[mypy] Add/fix type annotations for boolean_algebra
76b76df
@CodeHermyt
[mypy] Add/fix type annotations for boolean_algebra
dc17c67
@CodeHermyt
[mypy] Add/fix annotations for boolean_algebra
1ef4243
@poyea
poyea approved these changes Feb 4, 2021
View changes
Copy link
Member

@poyea poyea left a comment

Thank you for your pull request!🤩
@poyea poyea merged commit 97b6ca2 into TheAlgorithms:master Feb 4, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
peRFectBeliever added a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@CodeHermyt @peRFectBeliever
[mypy] Add/fix type annotations for boolean_algebra (TheAlgorithms#4172)
0d43641 
* [mypy] Add/fix type annotations for boolean_algebra

* [mypy] Add/fix type annotations for boolean_algebra

* [mypy] Add/fix annotations for boolean_algebra
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@CodeHermyt
[mypy] Add/fix type annotations for boolean_algebra (TheAlgorithms#4172)
96e1060 
* [mypy] Add/fix type annotations for boolean_algebra

* [mypy] Add/fix type annotations for boolean_algebra

* [mypy] Add/fix annotations for boolean_algebra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyea poyea

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@CodeHermyt @poyea