PEP 484: Mark as Final #1942
Draft
PEP 484: Mark as Final #1942
+1
−1
Conversation
PEP 484 is still marked as "Provisional", but as @Fidget-Spinner pointed out in python/typing#805, it shouldn't be any more. python/cpython#16204 removed talk about typing's provisional status from the module docs, and enhancements to typing have been in the form of new PEPs for the last few release cycles. Going to mark this as a draft so Guido can have a chance to comment once he's back.
|
Thanks for the fix Jelle! PS. I recently stopped @ people inside my commits (or the first message in a PR), see this to learn more: https://mail.python.org/archives/list/python-committers@python.org/thread/OCVQ6IYOVTVYW7ADDNOHKR7JDRBYLM3T/. I think it shouldn't matter as long as you squash-merge with a separate commit message though. |
|
I believe that was a GitHub bug that has since been fixed. Still I'll make sure to remove your name in case the bug reappears :) |
Thanks :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PEP 484 is still marked as "Provisional", but as @Fidget-Spinner pointed out in python/typing#805, it shouldn't be any more. python/cpython#16204 removed talk about typing's provisional status from the module docs, and enhancements to typing have been in the form of new PEPs for the last few release cycles.
Going to mark this as a draft so Guido can have a chance to comment once he's back.