Skip to content

fix(41299): Support Intl.NumberFormat.formatToParts in ES2018 #44566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

rastenis
Copy link
Contributor

Fixes #41299

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Jun 12, 2021
@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added the lib update PR modifies files in the `lib` folder label Jul 9, 2021
@rastenis rastenis marked this pull request as ready for review July 9, 2021 10:33
@rastenis
Copy link
Contributor Author

rastenis commented Jul 9, 2021

I have moved formatToParts to ES2018, and subsequently removed esnext.intl.d.ts, as it was empty after the migration. Everything seems OK, but I'd like a second set of eyes to check if I have completed all of the redirections and removals properly.

@sandersn sandersn requested review from sandersn and orta July 15, 2021 23:04
@orta
Copy link
Contributor

orta commented Sep 8, 2021

Thanks @Scharkee - I've taken this and merged it into 4.5 with #45647

@orta orta closed this Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug lib update PR modifies files in the `lib` folder
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Support Intl.NumberFormat.formatToParts in ES2018
3 participants