Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The links returning 404 should be removed. #1590

Open
marekdano opened this issue Mar 19, 2021 · 26 comments
Open

The links returning 404 should be removed. #1590

marekdano opened this issue Mar 19, 2021 · 26 comments

Comments

@marekdano
Copy link
Collaborator

@marekdano marekdano commented Mar 19, 2021

Here is a list of links that return 404

https://apility.io/apidocs/
http://developer.linkedin.com/docs/rest-api
https://sentim-api.herokuapp.com/ works
https://quarantine.country/coronavirus/api/ works

https://blog.mugenmonkey.com/2017/09/10/ds3-api.html
https://developer.walmartlabs.com/docs
https://taylor.rest

Please feel free to add more broken links when you find them.

@marekdano
Copy link
Collaborator Author

@marekdano marekdano commented Mar 19, 2021

Should we remove the broken links?

@matheusfelipeog
Copy link
Collaborator

@matheusfelipeog matheusfelipeog commented Mar 19, 2021

Should we remove the broken links?

I believe so. I see no reason to keep them if they are broken. 🤔

@yannbertrand
Copy link
Collaborator

@yannbertrand yannbertrand commented Mar 22, 2021

Let's remove them 🙂

@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented Mar 24, 2021

Ofcourse.

matheusfelipeog added a commit that referenced this issue Mar 27, 2021
Issue reference #1590
@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented Apr 2, 2021

There's a PR #1270 regarding the link http://developer.linkedin.com/docs/rest-api . I had reviewed it and ask for the feedback of the author.

@Anmoldeep1509
Copy link
Contributor

@Anmoldeep1509 Anmoldeep1509 commented Apr 2, 2021

Is the issue closed, if not, may I verify and remove the bad links?

@marekdano
Copy link
Collaborator Author

@marekdano marekdano commented Apr 2, 2021

The issue is still open.

@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented Apr 2, 2021

Is the issue closed, if not, may I verify and remove the bad links?

Yeah! you can go ahead.

@Anmoldeep1509
Copy link
Contributor

@Anmoldeep1509 Anmoldeep1509 commented Apr 3, 2021

API STATUS API STATUS
https://apility.io/apidocs/ Already Removed Down
http://developer.linkedin.com/docs/rest-api Need to remove Down
https://sentim-api.herokuapp.com/ Need to add Up
https://quarantine.country/coronavirus/api/ Already Added Up

This is the current status of APIs,
we have one working, may I add it back? (naturally following the contribution guidelines)

@marekdano
Copy link
Collaborator Author

@marekdano marekdano commented Apr 12, 2021

@Anmoldeep1509 https://quarantine.country/coronavirus/api/ is UP again.

@Anmoldeep1509
Copy link
Contributor

@Anmoldeep1509 Anmoldeep1509 commented Apr 12, 2021

@Anmoldeep1509 https://quarantine.country/coronavirus/api/ is UP again.

yes, thanks, checked just now, it is working, updating the table,

btw, do we have any MD code to add besides the API - to show if it is up or not?

Like I know a few repos where the MD code checks if the website is up or not, similar will be needed for this case.

@marekdano
Copy link
Collaborator Author

@marekdano marekdano commented Apr 13, 2021

@yannbertrand do we have "MD code checks"?

@yannbertrand
Copy link
Collaborator

@yannbertrand yannbertrand commented Apr 13, 2021

What do you mean by MD code?

Btw I'd say it's a good API design practice to expose a GET /status endpoint

@Anmoldeep1509
Copy link
Contributor

@Anmoldeep1509 Anmoldeep1509 commented Apr 14, 2021

What do you mean by MD code?

Btw I'd say it's a good API design practice to expose a GET /status endpoint

wisdom at its best ❤️

@Anmoldeep1509
Copy link
Contributor

@Anmoldeep1509 Anmoldeep1509 commented Apr 16, 2021

Pushed Changes - Please check PR #1650

pawelborkar added a commit that referenced this issue Apr 16, 2021
Added Sentium API - Issue #1590
@vmbansal2001
Copy link

@vmbansal2001 vmbansal2001 commented Apr 17, 2021

is this issue still open?

@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented Apr 18, 2021

is this issue still open?

Yup please check if you can find one. Although the links mention here has been fixed.

@ananya2023
Copy link

@ananya2023 ananya2023 commented May 3, 2021

I removed a broken link .Now where should I place the new code

@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented May 3, 2021

@ananya2023
Please make a PR regarding the same.
We'll review it and if everything looks good, we'll either merge it into the master or give you a feedback.

@marekdano
Copy link
Collaborator Author

@marekdano marekdano commented May 3, 2021

@ananya2023
This guide can help you for creating a new PR.

@abitrolly
Copy link

@abitrolly abitrolly commented May 15, 2021

I am thinking about availability checker that will at least archive the reason for removal after few months (with an optional outreach and investigation if anyone is interested).

@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented May 15, 2021

@abitrolly
Yeah. Sounds good.

@iamjoker021 iamjoker021 mentioned this issue May 22, 2021
0 of 2 tasks complete
@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented May 23, 2021

This link is broken
https://blog.mugenmonkey.com/2017/09/10/ds3-api.html

This URL is showing privacy notice
https://developer.walmartlabs.com/docs

@iamjoker021 iamjoker021 mentioned this issue May 23, 2021
0 of 2 tasks complete
@pawelborkar pawelborkar linked a pull request that will close this issue May 23, 2021
0 of 2 tasks complete
@marekdano
Copy link
Collaborator Author

@marekdano marekdano commented May 25, 2021

This link is broken too
https://taylor.rest

@saisumanthkumar
Copy link
Contributor

@saisumanthkumar saisumanthkumar commented May 27, 2021

If a link no longer accepting new clients ,can we send a PR by removing that link ??

@pawelborkar
Copy link
Collaborator

@pawelborkar pawelborkar commented May 27, 2021

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

10 participants