Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2 #26884

Merged
merged 5 commits into from Jul 14, 2021
Merged

bpo-42064: Move sqlite3 exceptions to global state, part 2 of 2 #26884

merged 5 commits into from Jul 14, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 23, 2021 •
edited by miss-islington

https://bugs.python.org/issue42064

Automerge-Triggered-By: GH:encukou

@erlend-aasland erlend-aasland requested a review from encukou Jun 23, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021

FYI, for check_cursor and pysqlite_check_connection, we cannot rely on the connection context exception pointers (at least not for the early sanity checks), so I'm using the global state in those methods.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jun 23, 2021

(Re-opening to trigger CI again)

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 5, 2021

cc. @encukou

encukou
encukou reviewed Jul 13, 2021
View changes
Modules/_sqlite/module.c Outdated Show resolved Hide resolved
Erlend E. Aasland added 2 commits Jul 13, 2021
@encukou encukou added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jul 14, 2021
encukou
encukou approved these changes Jul 14, 2021
View changes
Copy link
Member

@encukou encukou left a comment

Looks good, thanks!

@miss-islington miss-islington merged commit 0516299 into python:main Jul 14, 2021
12 checks passed
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Jul 14, 2021

Looks good, thanks!

Thanks for reviewing!

@erlend-aasland erlend-aasland deleted the sqlite-move-err/2 branch Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encukou encukou

@berkerpeksag berkerpeksag

Assignees
No one assigned
Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erlend-aasland @encukou @the-knights-who-say-ni @bedevere-bot @miss-islington