bpo-40528: Implement a metadata system for ASDL Generator #20193
Conversation
|
Re-triggering CI |
|
Thanks @pablogsal, it looks like everything is passing now. |
|
@isidentical Can you rebase? |
isidentical
force-pushed the
isidentical:bpo-40528-metadata
branch
from
8546a43
to
d5020da
Sure, rebased! |
isidentical
force-pushed the
isidentical:bpo-40528-metadata
branch
from
d5020da
to
25b3f0f
ASDL Generator was lack of proper annotation related to generated module. This patch implements a MetadataVisitor that produces a metadata object to pass to other visitors that are visiting that same module. For the inital patch, it dynamically retrieves int sequences (like cmpop), that was previously hardcoded. It offers an interface that is easy to extend.
isidentical
force-pushed the
isidentical:bpo-40528-metadata
branch
from
25b3f0f
to
73800af
isidentical
merged commit 35ad425
into
python:main
20 checks passed
20 checks passed
bedevere/news
"skip news" label found
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ASDL Generator was lack of proper annotation related to the generated
module. This patch implements a MetadataVisitor that produces a
metadata object to pass to other visitors that are visiting that
same module. For the initial patch, it dynamically retrieves int
sequences (like cmpop), that was previously hardcoded. It offers
an interface that is easy to extend.
https://bugs.python.org/issue40528