Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows #25414

Merged
merged 3 commits into from Oct 19, 2021
Merged

bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows #25414

merged 3 commits into from Oct 19, 2021

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 14, 2021 •
edited by bedevere-bot

@erlend-aasland erlend-aasland requested a review from a team as a code owner Apr 14, 2021
@altermark
Copy link

altermark commented Apr 28, 2021

Please note, that SQLITE_OMIT_DEPRECATED leaves out not only some SQLite C API functions, but also some SQL PRAGMAs, that are in use, so this option WILL break applications.

There should be a much more prominent warning in the documentation, than 'Optimise SQLite builds on Windows' if this patch will be merged as is.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 28, 2021

Please note, that SQLITE_OMIT_DEPRECATED leaves out not only some SQLite C API functions, but also some SQL PRAGMAs, that are in use, so this option WILL break applications.

There should be a much more prominent warning in the documentation, than 'Optimise SQLite builds on Windows' if this patch will be merged as is.

Good point! I'll leave that out. Thanks.

@erlend-aasland erlend-aasland changed the title bpo-43851: Optimise SQLite builds on Windows bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows Apr 28, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented May 4, 2021

@zooba FYI, rebased onto main to resolve conflicts.

@erlend-aasland erlend-aasland requested a review from zooba May 31, 2021
@zooba zooba merged commit 8702b66 into python:main Oct 19, 2021
13 checks passed
@erlend-aasland erlend-aasland deleted the bpo-43851/win branch Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

@zooba zooba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@erlend-aasland @altermark @zooba @the-knights-who-say-ni @bedevere-bot