bpo-44287: asyncio test_popen() uses longer timeout #26832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pablogsal: Let me introduce to you the battle-tested timeout. |
corona10
reviewed
Jun 21, 2021
| @@ -107,7 +107,8 @@ def test_popen(self): | |||
|
|
|||
| events = [ovin.event, ovout.event, overr.event] | |||
| # Super-long timeout for slow buildbots. | |||
| res = _winapi.WaitForMultipleObjects(events, True, 10000) | |||
| res = _winapi.WaitForMultipleObjects(events, True, | |||
| support.SHORT_TIMEOUT * 1000) | |||
There was a problem hiding this comment.
TypeError: WaitForMultipleObjects() argument 3 must be int, not float
support.SHORT_TIMEOUT looks like float value (30.0)
There was a problem hiding this comment.
Oh right, it should now be fixed.
corona10
approved these changes
Jun 21, 2021
Fix asyncio test_popen() of test_windows_utils by using a longer timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT timeout rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but it is made longer on slow buildbots. WaitForMultipleObjects() timeout argument is in milliseconds.
It is since I updated my PR. |
|
Thanks @vstinner for the PR |
|
GH-26841 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2021
Fix asyncio test_popen() of test_windows_utils by using a longer timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT timeout rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but it is made longer on slow buildbots. WaitForMultipleObjects() timeout argument is in milliseconds. (cherry picked from commit be1cb32) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 21, 2021
Fix asyncio test_popen() of test_windows_utils by using a longer timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT timeout rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but it is made longer on slow buildbots. WaitForMultipleObjects() timeout argument is in milliseconds. (cherry picked from commit be1cb32) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-26842 is a backport of this pull request to the 3.9 branch. |
miss-islington
added a commit
that referenced
this pull request
Jun 22, 2021
Fix asyncio test_popen() of test_windows_utils by using a longer timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT timeout rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but it is made longer on slow buildbots. WaitForMultipleObjects() timeout argument is in milliseconds. (cherry picked from commit be1cb32) Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington
added a commit
that referenced
this pull request
Jun 22, 2021
Fix asyncio test_popen() of test_windows_utils by using a longer timeout. Use military grade battle-tested test.support.SHORT_TIMEOUT timeout rather than a hardcoded timeout of 10 seconds: it's 30 seconds by default, but it is made longer on slow buildbots. WaitForMultipleObjects() timeout argument is in milliseconds. (cherry picked from commit be1cb32) Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix asyncio test_popen() of test_windows_utils by using a longer
timeout. Use battle-tested test.support.SHORT_TIMEOUT timeout rather
than a hardcoded timeout of 10 seconds: it's 30 seconds by default,
but it is made longer on slow buildbots.
WaitForMultipleObjects() timeout argument is in milliseconds.
https://bugs.python.org/issue44287