Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42588: Update static_order method docs #26834

Merged
merged 3 commits into from Jun 29, 2021
Merged

bpo-42588: Update static_order method docs #26834

merged 3 commits into from Jun 29, 2021

Conversation

akulakov
Copy link
Contributor

@akulakov akulakov commented Jun 21, 2021 •
edited by bedevere-bot

This PR is based on the suggested clarification of the docs by Ran Benita (see the issue comments).

https://bugs.python.org/issue42588

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jun 21, 2021
@nanjekyejoannah nanjekyejoannah changed the title bpo-42588: Updated static_order method docs bpo-42588: Update static_order method docs Jun 22, 2021
nanjekyejoannah
nanjekyejoannah reviewed Jun 22, 2021
View changes
Copy link
Member

@nanjekyejoannah nanjekyejoannah left a comment

Do we really need a news entry for this?

@akulakov
Copy link
Contributor Author

akulakov commented Jun 22, 2021

@nanjekyejoannah it probably does not, I wasn't quite sure -- I can remove if you think so.

@pablogsal
Copy link
Member

pablogsal commented Jun 29, 2021

Thanks @nanjekyejoannah for the review and thanks @akulakov for the PR! 🚀

@pablogsal pablogsal merged commit 0d7f797 into python:main Jun 29, 2021
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Jun 29, 2021

Thanks @akulakov for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2021
@akulakov @miss-islington
bpo-42588: Update the docs for the TopologicalSorter.static_order() m…
8ce1a67 
…ethod (pythonGH-26834)

(cherry picked from commit 0d7f797)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 29, 2021

GH-26951 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 29, 2021
@akulakov @miss-islington
bpo-42588: Update the docs for the TopologicalSorter.static_order() m…
042e832 
…ethod (pythonGH-26834)

(cherry picked from commit 0d7f797)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 29, 2021

GH-26952 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Jun 29, 2021
@miss-islington @akulakov
bpo-42588: Update the docs for the TopologicalSorter.static_order() m…
d9fc4c3 
…ethod (GH-26834)

(cherry picked from commit 0d7f797)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@akulakov
Copy link
Contributor Author

akulakov commented Jun 29, 2021

@nanjekyejoannah thanks for reviewing :)

pablogsal pushed a commit that referenced this pull request Jun 29, 2021
@miss-islington @akulakov
bpo-42588: Update the docs for the TopologicalSorter.static_order() m…
3ba65cd 
…ethod (GH-26834) (GH-26952)

(cherry picked from commit 0d7f797)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanjekyejoannah nanjekyejoannah

@pablogsal pablogsal

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@akulakov @pablogsal @miss-islington @bedevere-bot @nanjekyejoannah @the-knights-who-say-ni