STY Ensures that "flake8 ." works #20298
Merged
Conversation
|
Yes, I agree. Thanks! |
| ax1 = plt.subplot2grid((3, 1), (0, 0), rowspan=2) | ||
| ax2 = plt.subplot2grid((3, 1), (2, 0)) |
Comment on lines
84
to
85
ogrisel
Jun 18, 2021
Member
what's wrong with the current code? If fig was not used, there is no point assigning this variable.
thomasjpfan
Jun 18, 2021
Author
Member
I do not think fig.subplot2grid exists. I added plt.subplot2grid(..., fig=fig) to be more OO.
| .3 * np.random.normal(size=2), | ||
| mode='constant', | ||
| ).ravel() | ||
| def shift(x): return ndimage.shift(x.reshape((8, 8)), |
NicolasHug
Jun 18, 2021
Member
I thought we told flake8 to ignore that kind of thing?
in setup.cfg we ignore:
E731, # do not assign a lambda expression, use a def
thomasjpfan
Jun 18, 2021
Author
Member
Autopep8 did its magic here. I reverted the change and just fixed this part manually
|
Just questions from me but LGTM anyway, thanks Thomas |
| .3 * np.random.normal(size=2), | ||
| mode='constant', | ||
| ).ravel() | ||
| def shift(x): return ndimage.shift(x.reshape((8, 8)), |
NicolasHug
Jun 18, 2021
Member
I thought we told flake8 to ignore that kind of thing?
in setup.cfg we ignore:
E731, # do not assign a lambda expression, use a def
|
LGTM! |
ogrisel
merged commit 81dde3a
into
scikit-learn:main
24 of 26 checks passed
24 of 26 checks passed
Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}-${{ matrix.manylinux_image }}
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas)
Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl)
Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py37_pip_openblas_32bit)
Windows py37_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl)
macOS pylatest_conda_forge_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp)
macOS pylatest_conda_mkl_no_openmp succeeded
Details
|
Merged! |
|
Circle CI was still running but the lint step was already green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reference Issues/PRs
Closes #20296
What does this implement/fix? Explain your changes.
I ran:
And did a few manual adjustments. I do not think there are many recent PRs that touch these lines, so I think it is okay to fix these for flake8.
CC @rth