TST Enable numpydoc validation default #20304
Merged
Conversation
|
Good idea and LGTM. |
|
Thanks @thomasjpfan ! |
|
Should we maybe do this as part of the lint job if it doesn't take too long? |
We can try to do this as a part of lint when numpydoc validation passes everywhere. |
|
OK, that works. |
rth
merged commit bb6117b
into
scikit-learn:main
30 checks passed
30 checks passed
Build wheel for cp${{ matrix.python }}-${{ matrix.platform_id }}-${{ matrix.manylinux_image }}
Details
scikit-learn.scikit-learn (Linux pylatest_pip_openblas_pandas)
Linux pylatest_pip_openblas_pandas succeeded
Details
scikit-learn.scikit-learn (Linux_Runs pylatest_conda_mkl)
Linux_Runs pylatest_conda_mkl succeeded
Details
scikit-learn.scikit-learn (Windows py37_pip_openblas_32bit)
Windows py37_pip_openblas_32bit succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_forge_mkl)
macOS pylatest_conda_forge_mkl succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda_mkl_no_openmp)
macOS pylatest_conda_mkl_no_openmp succeeded
Details
sakib-rahman-bangladesh
added a commit
to sakib-rahman-bangladesh/scikit-learn
that referenced
this pull request
Jun 22, 2021
TST Enable numpydoc validation default (scikit-learn#20304)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR changes the logic of this to have an "ignore list". This way we can ensure that our docstrings are always validated once we fix the ones in
DOCSTRING_IGNORE_LIST.I see this as a sprint item where contributors can:
DOCSTRING_IGNORE_LIST.pytest maint_tools/test_docstrings.py -k SGDClassifierCC @rth