Spaces #86274
Spaces #86274
Conversation
|
Some changes occurred in HTML/CSS/JS. Some changes occurred in src/tools/rustfmt. Some changes occurred in src/tools/clippy. |
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! Wonder if it would worth it to add a tidy check for that... |
|
You are welcome! Why not? |
|
For me we should, but not sure if it's worth it, that's pretty much all. :) Considering you made changes to |
|
Ok |
|
Some of these changes are stripping two consecutive spaces off the end of lines in markdown files, which I believe is significant/possibly intentional due to how markdown does line breaking. Are we sure all these changes are desired, including for the tools that are primarily developed externally? |
|
@calebcartwright, You're absolutely right about the two spaces in markdown. Add two spaces back |
| if (flags != 1) /* not lone -s */ | ||
| -- | ||
| -- | ||
| 2.25.1 | ||
|
|
bjorn3
Jun 14, 2021
Contributor
Patch files shouldn't be changed IMO. These spaces are inserted by git, so removing them would mean that applying and recreating the patch would result in a different patch file.
|
@bjorn3, need your review. |
|
After you have reverted the indicated change please squash all commits to keep the git history a bit cleaner and avoid polluting the |
src/ci/docker/host-x86_64/dist-aarch64-linux/aarch64-linux-gnu.config
Outdated
Show resolved
Hide resolved
alexander-melentyev
force-pushed the
alexander-melentyev:spaces
branch
from
8dd5c97
to
e84c9ae
|
@bjorn3 thank you! All your recommended - done. Please check. |
|
|
Rollup of 9 pull requests Successful merges: - rust-lang#86192 (Make OR_PATTERNS_BACK_COMPAT be a 2021 future-incompatible lint) - rust-lang#86248 (Add a regression test for issue-85113) - rust-lang#86274 (Spaces) - rust-lang#86349 (Add regression test for issue rust-lang#78632) - rust-lang#86424 (rustfmt: load nested out-of-line mods correctly) - rust-lang#86472 (Fix CI to fetch master on beta channel) - rust-lang#86473 (Rustdoc: Account for const-unstable functions) - rust-lang#86495 (Improve `proc_macro::{Punct, Spacing}` documentation) - rust-lang#86503 (Fix rust.css fonts.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 9 pull requests Successful merges: - rust-lang#86192 (Make OR_PATTERNS_BACK_COMPAT be a 2021 future-incompatible lint) - rust-lang#86248 (Add a regression test for issue-85113) - rust-lang#86274 (Spaces) - rust-lang#86349 (Add regression test for issue rust-lang#78632) - rust-lang#86424 (rustfmt: load nested out-of-line mods correctly) - rust-lang#86472 (Fix CI to fetch master on beta channel) - rust-lang#86473 (Rustdoc: Account for const-unstable functions) - rust-lang#86495 (Improve `proc_macro::{Punct, Spacing}` documentation) - rust-lang#86503 (Fix rust.css fonts.) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
No description provided.