Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic in return_type_impl_trait #86505

Merged
merged 3 commits into from Jun 25, 2021
Merged

Do not panic in return_type_impl_trait #86505

merged 3 commits into from Jun 25, 2021

Conversation

@JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Jun 21, 2021

Fixes #86483

@rust-highfive
Copy link
Collaborator

@rust-highfive rust-highfive commented Jun 21, 2021

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

@jackh726 jackh726 left a comment

I think it's better to enumerate the Items that are relevant (i.e. closures and fn items), rather than checking for items to return early from.

r=me with that, or as is

@JohnTitor JohnTitor force-pushed the JohnTitor:fix-86483 branch from 39e5581 to 78912f9 Jun 24, 2021
@JohnTitor JohnTitor force-pushed the JohnTitor:fix-86483 branch from 78912f9 to 9323a28 Jun 24, 2021
@JohnTitor
Copy link
Member Author

@JohnTitor JohnTitor commented Jun 24, 2021

@jackh726 Applied your suggestion, could you take a look once more in case I overlook some cases?

@jackh726
Copy link
Contributor

@jackh726 jackh726 commented Jun 24, 2021

@bors r+ rollup

@bors
Copy link
Contributor

@bors bors commented Jun 24, 2021

📌 Commit 9323a28 has been approved by jackh726

m-ou-se added a commit to m-ou-se/rust that referenced this pull request Jun 24, 2021
@bors
Copy link
Contributor

@bors bors commented Jun 25, 2021

Testing commit 9323a28 with merge 117799b...

@bors
Copy link
Contributor

@bors bors commented Jun 25, 2021

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 117799b to master...

@bors bors merged commit 117799b into rust-lang:master Jun 25, 2021
11 checks passed
11 checks passed
@github-actions
PR (mingw-check, ubuntu-latest-xl)
Details
@github-actions
PR (x86_64-gnu-llvm-10, ubuntu-latest-xl)
Details
@github-actions
PR (x86_64-gnu-tools, 1, ubuntu-latest-xl)
Details
@github-actions
auto
Details
@github-actions
master
Details
@github-actions
bors build finished
Details
@github-actions
bors build finished
Details
@github-actions
bors build finished
Details
@github-actions
bors build finished
Details
@bors
homu Test successful
Details
@rustbot rustbot added this to the 1.55.0 milestone Jun 25, 2021
@JohnTitor JohnTitor deleted the JohnTitor:fix-86483 branch Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants