Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use es5 for async module runtime #13659

Merged
merged 1 commit into from Jun 29, 2021
Merged

use es5 for async module runtime #13659

merged 1 commit into from Jun 29, 2021

Conversation

yiminghe
Copy link
Contributor

@yiminghe yiminghe commented Jun 29, 2021

**What existing problem does the pull request solve?

some tools will check whether build assets conform to es5.

What kind of change does this PR introduce?

code style change

Did you add tests for your changes?

No need

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

No need

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Jun 29, 2021

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Jun 29, 2021

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

sokra
sokra approved these changes Jun 29, 2021
@webpack-bot
Copy link
Contributor

@webpack-bot webpack-bot commented Jun 29, 2021

@yiminghe Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@sokra
Copy link
Member

@sokra sokra commented Jun 29, 2021

Please also make sure to sign the CLA: https://cla.js.foundation/webpack/webpack?pullRequest=13659

@yiminghe
Copy link
Contributor Author

@yiminghe yiminghe commented Jun 29, 2021

Please also make sure to sign the CLA: https://cla.js.foundation/webpack/webpack?pullRequest=13659

signed

@sokra sokra merged commit c409811 into webpack:main Jun 29, 2021
42 of 45 checks passed
@sokra
Copy link
Member

@sokra sokra commented Jun 29, 2021

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants