Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44434: Remove useless calls to PyThread_exit_thread() #26943

Merged
merged 1 commit into from Jun 29, 2021
Merged

bpo-44434: Remove useless calls to PyThread_exit_thread() #26943

merged 1 commit into from Jun 29, 2021

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 28, 2021 •
edited

Remove useless calls to PyThread_exit_thread() in two unit tests of
_testcapi and _testembed modules.

Co-authored-by: Alexey Izbyshev izbyshev@ispras.ru

https://bugs.python.org/issue44434
@vstinner @izbyshev
bpo-44434: Remove useless calls to PyThread_exit_thread()
347234b 
Remove useless calls to PyThread_exit_thread() in two unit tests of
_testcapi and _testembed modules.

Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
@vstinner vstinner force-pushed the vstinner:exit_thread_tests branch from 72d7627 to 347234b Jun 28, 2021
@vstinner
Copy link
Member Author

@vstinner vstinner commented Jun 28, 2021

PR based on @izbyshev's PR #24241.
@vstinner vstinner mentioned this pull request Jun 28, 2021
Closed
@vstinner vstinner merged commit 48e3a1d into python:main Jun 29, 2021
12 checks passed
12 checks passed
@github-actions
Check for source changes
Details
@github-actions
Check if generated files are up to date
Details
@github-actions
Windows (x86)
Details
@github-actions
Windows (x64)
Details
@github-actions
macOS
Details
@github-actions
Ubuntu
Details
@github-actions
Ubuntu SSL tests with OpenSSL
Details
@github-actions
Address sanitizer Address sanitizer
Details
Azure Pipelines PR #20210628.27 succeeded
Details
@travis-ci
Travis CI - Pull Request Build Passed
Details
@bedevere-bot
bedevere/issue-number Issue number 44434 found
Details
@bedevere-bot
bedevere/news "skip news" label found
@vstinner vstinner deleted the vstinner:exit_thread_tests branch Jun 29, 2021
@vstinner
Copy link
Member Author

@vstinner vstinner commented Jun 29, 2021

I don't think that it's worth it to backport this change to 3.9 and 3.10 since it only impacts tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot