Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43625: Enhance csv sniffer has_headers() to be more accurate #26939

Merged
merged 9 commits into from Jul 30, 2021
Merged

bpo-43625: Enhance csv sniffer has_headers() to be more accurate #26939

merged 9 commits into from Jul 30, 2021

Conversation

@akulakov
Copy link
Contributor

@akulakov akulakov commented Jun 28, 2021 •
edited

Based on the patch by @smontanaro , updated by A. Kulakov

https://bugs.python.org/issue43625
@akulakov akulakov marked this pull request as draft Jun 29, 2021
smontanaro
smontanaro reviewed Jun 29, 2021
View changes
Lib/test/test_csv.py Outdated Show resolved Hide resolved
@akulakov akulakov marked this pull request as ready for review Jun 29, 2021
smontanaro
smontanaro reviewed Jun 29, 2021
View changes
Lib/csv.py Outdated Show resolved Hide resolved
@smontanaro
Copy link
Contributor

@smontanaro smontanaro commented Jun 29, 2021

I added one niggling comment, but otherwise LGTM.

@akulakov
Copy link
Contributor Author

@akulakov akulakov commented Jun 29, 2021

@smontanaro thanks for the review!, - updated to catch specific exceptions..

@github-actions
Copy link

@github-actions github-actions bot commented Jul 30, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jul 30, 2021
@ambv ambv merged commit ceea579 into python:main Jul 30, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 30, 2021

Thanks @akulakov for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 30, 2021
@akulakov @miss-islington
bpo-43625: Enhance csv sniffer has_headers() to be more accurate (pyt…
dbbb9f2 
…honGH-26939)

(cherry picked from commit ceea579)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 30, 2021

GH-27494 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit that referenced this issue Jul 30, 2021
@akulakov @miss-islington
bpo-43625: Enhance csv sniffer has_headers() to be more accurate (GH-…
440c9f7 
…26939) (GH-27494)

(cherry picked from commit ceea579)

Co-authored-by: andrei kulakov <andrei.avk@gmail.com>
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@akulakov @JuniorJPDJ
bpo-43625: Enhance csv sniffer has_headers() to be more accurate (pyt…
3388e00 
…honGH-26939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smontanaro smontanaro

Assignees
No one assigned
Labels
CLA signed stale
Projects
None yet
Milestone
No milestone
6 participants
@akulakov @smontanaro @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni