Skip to content

feat: Add Vigenère cipher #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 20, 2020
Merged

feat: Add Vigenère cipher #962

merged 7 commits into from
Jul 20, 2020

Conversation

imdeep2905
Copy link
Contributor

@imdeep2905 imdeep2905 commented Jul 20, 2020 •
edited by gitpod-io bot
Loading

Description of Change

Added Vigenère cipher as ciphers/vigenere_cipher.cpp

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

kvedala
kvedala approved these changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@kvedala kvedala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise
Good work 👍
Thanks

@imdeep2905 @kvedala
Update ciphers/vigenere_cipher.cpp
2a01d4f 
Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>
Panquesito7
Panquesito7 requested changes Jul 20, 2020
View reviewed changes
@imdeep2905 @Panquesito7
Update ciphers/vigenere_cipher.cpp
27bc82f 
Co-authored-by: David Leal <halfpacho@gmail.com>
Panquesito7
Panquesito7 approved these changes Jul 20, 2020
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job; LGTM. 👍
Thanks for your contribution.

@kvedala this can be merged.

@kvedala kvedala merged commit cf562f2 into TheAlgorithms:master Jul 20, 2020
@imdeep2905 imdeep2905 deleted the vigenere_cipher branch July 20, 2020 17:51
liushubin-gitHub pushed a commit to liushubin-gitHub/C-Plus-Plus that referenced this pull request Jul 29, 2020
@imdeep2905 @kvedala
@Panquesito7 @liushubin-gitHub
feat: Add Vigenère cipher (TheAlgorithms#962)
3965a1d 
* Added Vigenere Cipher

* Added size_t instead of int in for loop

* Update ciphers/vigenere_cipher.cpp

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>

* Update ciphers/vigenere_cipher.cpp

Co-authored-by: David Leal <halfpacho@gmail.com>

Co-authored-by: Krishna Vedala <7001608+kvedala@users.noreply.github.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
This was referenced Aug 6, 2020
Merged
Merged
Closed
Merged
Closed
Closed
Closed
@Panquesito7 Panquesito7 mentioned this pull request Aug 21, 2020
Merged
@imdeep2905 imdeep2905 mentioned this pull request Aug 21, 2020
Closed
8 tasks
Rp-sushil added a commit to Rp-sushil/C-Plus-Plus that referenced this pull request Aug 21, 2020
@Rp-sushil
added a comment block like in TheAlgorithms#962.
b631eee
Rp-sushil added a commit to Rp-sushil/C-Plus-Plus that referenced this pull request Aug 21, 2020
@Rp-sushil
Changed has been made (TheAlgorithms#962 as a reference)
caed3dd
Rp-sushil added a commit to Rp-sushil/C-Plus-Plus that referenced this pull request Aug 21, 2020
@Rp-sushil
updated median_search (TheAlgorithms#962 as reference)
498db11
This was referenced Sep 2, 2020
Merged
Merged
This was referenced Sep 11, 2020
Closed
Merged
Merged
This was referenced Sep 24, 2020
Merged
Merged
This was referenced Oct 14, 2020
Merged
Closed
Merged
@Panquesito7 Panquesito7 mentioned this pull request Oct 25, 2020
Merged
8 tasks
@Panquesito7 Panquesito7 mentioned this pull request Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvedala kvedala kvedala approved these changes

@Panquesito7 Panquesito7 Panquesito7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imdeep2905 @kvedala @Panquesito7