Skip to content

/ vue-devtools

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Vue@1.x compat #534

Merged
merged 4 commits into from Jan 20, 2018
Merged

Improve Vue@1.x compat #534

merged 4 commits into from Jan 20, 2018

Conversation

@Akryum
Copy link
Member

@Akryum Akryum commented Jan 20, 2018

  • Fix Data editing for Vue@1.x (tested with 1.0.28)
  • Fix Vuex@1.x not having getters
Guillaume Chau added 4 commits Jan 20, 2018
Guillaume Chau
Test app
c18fbb7
Guillaume Chau
Fix data editing for Vue 1.x
815ba48
Guillaume Chau
Vuex test case
5b168b2
Guillaume Chau
Fix for Vuex@1.x getters
Loading status checks…
fb25061
@Akryum Akryum self-assigned this Jan 20, 2018
@Akryum Akryum added this to the v4.1.0 milestone Jan 20, 2018
@Akryum Akryum requested review from yyx990803, posva and michalsnik Jan 20, 2018
@Akryum Akryum added this to Review in v4.x Jan 20, 2018
@posva
posva approved these changes Jan 20, 2018
View changes
Copy link
Member

@posva posva left a comment

Tested with the provided file 👍
@Akryum Akryum merged commit c24a4e8 into vuejs:master Jan 20, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
v4.x automation moved this from Review to Done Jan 20, 2018
@Akryum Akryum deleted the Akryum:vue1-compat branch Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva

@yyx990803 yyx990803

@michalsnik michalsnik

Assignees

@Akryum Akryum

Labels
bug semver-patch vue 1.x
Projects
v4.x
Done
Milestone
v4.1.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@Akryum @posva