Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB: Use appropriate favicon when user has browser in dark mode #42314

Open
datapythonista opened this issue Jun 29, 2021 · 0 comments · May be fixed by #42325
Open

WEB: Use appropriate favicon when user has browser in dark mode #42314

datapythonista opened this issue Jun 29, 2021 · 0 comments · May be fixed by #42325

Comments

@datapythonista
Copy link
Member

@datapythonista datapythonista commented Jun 29, 2021

We've got two versions of our logo, one for light backgrounds, and another one for dark backgrounds: https://pandas.pydata.org/about/citing.html#brand-and-logo.

Modern browsers usually support a dark mode, and when users have it activated, our favicon (our logo for light backgrounds) doesn't look really nice:

Screenshot at 2021-06-29 13-18-05

Looks like there are ways to change the favicon colors (or the favicon itself I guess) based on the light theme of the browser user. For example, see this article: https://catalin.red/svg-favicon-light-dark-theme/

It'd be nice to show the dark background logo as a favicon to web visitors using a dark theme for their browser.

@DeviousLab DeviousLab linked a pull request that will close this issue Jun 30, 2021
4 tasks
@jreback jreback added this to the 1.4 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants