Topic/6 test data cleanup #3980
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request does not follow the contribution rules. Could you have a look? ❌ All commit messages should start with a JIRA issue key matching pattern › This message was automatically generated. |
…rk and update the section - re-enable tests - re-organize some tests - fix basic-type resolution in various cases from tests in both `hibernate-core` and `documentation` - updated the basic_types.adoc user-guide section + moved much of the "legacy" discussion to an appendix A major change here is the change to the `AdjustableBasicType` contract (previously `SqlTypeDescriptorIndicatorCapable`). We know pass along the "real" domain type to be able to use that in the adjustment. Mainly this was needed for better primitive/wrapper (and primitive/wrapper array) handling The basic-types section of the user-guide has been expanded and re-organized significantly, although it is not quite complete
- re-organize some tests - More work on basic_types.adoc
- changes to `ColumnTransformerTest` are related to "composite basics" not being supported, not problems with ColumnTransformer. - final failure in `org.hibernate.userguide.mapping.basic` is `SubselectTest#testRefreshLifecycle` which actually fails because refresh is not working properly
- fixed missing impls of the optional contract `org.hibernate.type.AdjustableBasicType`
sebersole
force-pushed
the
topic/6-test-data-cleanup
branch
from
52f4dfa to
ba645e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #3976
Reverts the last massive commit there and I'll be applying the pieces individually. This first commit deals with nationalized data problems. The next will deal with test data clean up