Skip to content

[GHA] Clarify some bits in the deps=high script #42007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jul 6, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix -
License MIT
Doc PR

I had some difficulty understanding how flipped tests worked. Luckily, @nicolas-grekas was available to answer some questions. However, I'm sure that I've forgotten the logic in about a week time, so I think it's worth clarifying the code a bit (but feel free to close if it's just me).

@carsonbot carsonbot added this to the 4.4 milestone Jul 6, 2021
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@fabpot
Copy link
Member

fabpot commented Jul 8, 2021

Thank you @wouterj.

@fabpot fabpot merged commit 09814d5 into symfony:4.4 Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants