Skip to content

[ErrorHandle] Remove a link from the exception page #42028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

This link is causing lots of confusion to some people, who think that we provide free support for open source Symfony projects. That's why we've decided to remove this link. Thanks!

@javiereguiluz javiereguiluz added this to the 4.4 milestone Jul 8, 2021
@javiereguiluz javiereguiluz requested a review from yceruto as a code owner July 8, 2021 08:50

<div class="help-link">
<a href="https://symfony.com/support">
<span class="icon"><?= $this->include('assets/images/icon-support.svg'); ?></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the icon-support.svg file or is it used elsewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any other occurrence, so I've removed the icon file too.

@fabpot
Copy link
Member

fabpot commented Jul 8, 2021

Thank you @javiereguiluz.

@fabpot fabpot merged commit 57e3c5f into symfony:4.4 Jul 8, 2021
@javiereguiluz javiereguiluz deleted the exception_page branch July 8, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants