feat: expose location and modifiers on before-input-event #29850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
approved these changes
Jul 7, 2021
electron-cation
bot
added
api-review/requested 
|
Release Notes Persisted
|
poiru
reviewed
Aug 3, 2021
| dict.Set("alt", (in.GetModifiers() & Modifiers::kAltKey) != 0); | ||
| dict.Set("meta", (in.GetModifiers() & Modifiers::kMetaKey) != 0); | ||
| dict.Set("location", GetKeyLocationCode(in)); | ||
| dict.Set("_modifiers", in.GetModifiers()); |
There was a problem hiding this comment.
@nornagon Curious why this is exposed?
There was a problem hiding this comment.
I left it as an escape hatch in case there are other modifiers which we don't currently expose elsewhere that an app wants to detect. It's undocumented, but this makes it possible to build a workaround in older versions of the app for detecting unsupported modifiers while we add support to newer versions.
BlackHole1
added a commit
to BlackHole1/electron
that referenced
this issue
Aug 30, 2021
…9850) * feat: expose location and modifiers on before-input-event * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Description of Change
This adds two new values to the
before-input-eventdetails object:locationand
modifiers. The latter matches the existing behavior ofInputEvent,previously only used for creating input events (e.g. with
WebContents.sendInputEvent).Closes #29845
Checklist
npm testpassesRelease Notes
Notes: Added
locationandmodifiersto the event properties provided in the'before-input-event'WebContents event.The text was updated successfully, but these errors were encountered: