Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.9] bpo-40897: Partially backport GH-22583's refactor of inspect.py to allow bugfix backports #27193

Merged
merged 1 commit into from Jul 17, 2021
Merged

[3.9] bpo-40897: Partially backport GH-22583's refactor of inspect.py to allow bugfix backports #27193

merged 1 commit into from Jul 17, 2021

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Jul 16, 2021 •
edited by bedevere-bot

The backport in this PR is entirely about the introduction of the internal partial _get_signature_of. No external functional change.

The goal is to allow 3.9 backport of #27177.

https://bugs.python.org/issue40897
@ambv ambv changed the title bpo-40897: Partially backport GH-22583's refactor of inspect.py to allow bugfix backports [3.9] bpo-40897: Partially backport GH-22583's refactor of inspect.py to allow bugfix backports Jul 16, 2021
@ambv ambv added the skip news label Jul 16, 2021
@ambv
Copy link
Contributor Author

@ambv ambv commented Jul 16, 2021

Skipped news for this one. There will be a NEWS entry for the bugfix in GH-27177.

@ambv ambv requested a review from gvanrossum Jul 16, 2021
@ambv
Copy link
Contributor Author

@ambv ambv commented Jul 16, 2021

Asked you for review @gvanrossum since you reviewed the original change in GH-22583.

gvanrossum
gvanrossum approved these changes Jul 16, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

LG

@ambv ambv merged commit ed2db9b into python:3.9 Jul 17, 2021
13 checks passed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 17, 2021

@ambv: Please replace # with GH- in the commit message next time. Thanks!

@ambv ambv deleted the bpo40897-backport branch Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
4 participants
@ambv @bedevere-bot @gvanrossum @the-knights-who-say-ni