Start using ConfigBuilder #15264
Merged
Start using ConfigBuilder #15264
Conversation
The new config builder looks much better to me than the old plain PHP arrays. Love it! Thanks Tobias. |
It's merged! |
Thank you for merging |
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Apr 21, 2021
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Config] Use plural name on array values | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Related: symfony/symfony-docs#15264 If we have a PrototypedArrayNode and the prototype is does not have a key (`->useAttributeAsKey('name')`). Then we know for sure that the value should be an array. See this example from `$framework->assets()` ```diff /** + * @param list<mixed> * @return $this */ - public function baseUrl($value): self + public function baseUrls(array $value): self { $this->baseUrls = $value; return $this; } ``` Commits ------- f564a7a [Config] Use plural name on array values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I start with 5 documents to see how it feels.