Skip to content
This repository has been archived by the owner. It is now read-only.

/ html Archived

Replace "XXX" with "issue" #1223

Merged
merged 1 commit into from Feb 19, 2018
Merged

Replace "XXX" with "issue" #1223

merged 1 commit into from Feb 19, 2018

Conversation

@edent
Copy link
Member

edent commented Feb 18, 2018

  • Easier to read
  • More consistent
  • Fixes #1216
@edent
Replace "XXX" with "issue"
Loading status checks…
07f7b85 
* Easier to read
* More consistent
* Fixes #1216
@chaals chaals added the editorial label Feb 18, 2018
@chaals
chaals approved these changes Feb 18, 2018
View changes
Copy link
Collaborator

chaals left a comment

Nice, thanks
@chaals
Copy link
Collaborator

chaals commented Feb 18, 2018

Oh wait. There is an .issue class already in the stylesheets that are added as part of building the spec, e.g. https://www.w3.org/StyleSheets/TR/2016/base.css - did you check how it comes out with that?
@edent
Copy link
Member Author

edent commented Feb 18, 2018

Looks like this.

monkeypatch

TBH, there's only the example issue and this monkey patch.
@chaals chaals merged commit c614116 into master Feb 19, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
ipr PR deemed acceptable.
Details
plehegar pushed a commit that referenced this pull request Feb 19, 2018
Travis CI
Built by Travis-CI: c614116 Replace "XXX" with "…
Loading status checks…
a24f148 
…issue" (#1223)
scottaohara added a commit that referenced this pull request Feb 19, 2018
@edent @scottaohara
Replace "XXX" with "issue" (#1223)
25d4676 
Fix #1216
@edent edent deleted the 1216-xxx-edent branch Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chaals chaals

Assignees
No one assigned
Labels
editorial
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@edent @chaals
You can’t perform that action at this time.