Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create N-bonacci.cpp #1306

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

@neha-hasija17
Copy link
Contributor

@neha-hasija17 neha-hasija17 commented Oct 16, 2020

This Pull Request is for HacktoberFest 2020

Description of Change

Checklist

  • Added description of change
  • Added file name matches File name guidelines
  • Added tests and example, test must pass
  • Added documentation so that the program is self-explanatory and educational - Doxygen guidelines
  • Relevant documentation/comments is changed or added
  • PR title follows semantic commit guidelines
  • Search previous suggestions before making a new one, as yours may be a duplicate.
  • I acknowledge that all my contributions will be made under the project's license.

Notes:

This Pull Request is for HacktoberFest 2020
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Code is not up to the repository standards.
Please read them carefully and follow them.

This Pull Request is for HacktoberFest 2020
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Documentation is not up to the Doxygen guidelines.
Please read them carefully and follow them.

This Pull Request is for HacktoberFest 2020
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 16, 2020
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Documentation is not up to the Doxygen guidelines.
Please read them carefully and follow them.

math/N-bonacci.cpp Outdated Show resolved Hide resolved
*In this code we take N and M as input where M is the number of terms
*to be printed of the N-bonacci series
*/
void N_bonacci(int n,int m){

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 17, 2020
Member

For how to document functions, please see #962 as a reference. 🙂

math/N-bonacci.cpp Outdated Show resolved Hide resolved
neha-hasija17 and others added 2 commits Oct 17, 2020
Co-authored-by: David Leal <halfpacho@gmail.com>
This Pull Request is for HacktoberFest 2020
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 17, 2020
@neha-hasija17
Copy link
Contributor Author

@neha-hasija17 neha-hasija17 commented Oct 17, 2020

@Panquesito7 please check it now, and let me know the error so I can resolve it asap.

math/N-bonacci.cpp Outdated Show resolved Hide resolved
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 18, 2020
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp Outdated Show resolved Hide resolved
neha-hasija17 and others added 2 commits Oct 18, 2020
Co-authored-by: David Leal <halfpacho@gmail.com>
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp Outdated Show resolved Hide resolved
math/n_bonacci.cpp Outdated Show resolved Hide resolved
while (t--) {
std::cout << "Enter the values of N and M : ";
std::cin >> n >> m;
N_bonacci(n, m);

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 18, 2020
Member

Please add self-test cases to ensure the algorithm works as expected. 🙂

This comment has been minimized.

@neha-hasija17

neha-hasija17 Oct 18, 2020
Author Contributor

please help me with the same

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program as a reference.

*In this code we take N and M as input where M is the number of terms
*to be printed of the N-bonacci series
*/
void N_bonacci(int n, int m) {

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 18, 2020
Member

Missing function documentation.

This comment has been minimized.

@neha-hasija17

neha-hasija17 Oct 18, 2020
Author Contributor

please help me in resolving this issue

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program or #962 as a reference.

math/n_bonacci.cpp Show resolved Hide resolved
Co-authored-by: David Leal <halfpacho@gmail.com>
neha-hasija17 and others added 2 commits Oct 18, 2020
Co-authored-by: David Leal <halfpacho@gmail.com>
Co-authored-by: David Leal <halfpacho@gmail.com>
@github-actions github-actions bot force-pushed the neha-hasija17:patch-1 branch 3 times, most recently from 9744e54 to 9acb16e Oct 18, 2020
@github-actions github-actions bot force-pushed the neha-hasija17:patch-1 branch from 9acb16e to 7070e79 Oct 18, 2020
@neha-hasija17 neha-hasija17 requested a review from Panquesito7 Oct 21, 2020
while (t--) {
std::cout << "Enter the values of N and M : ";
std::cin >> n >> m;
N_bonacci(n, m);

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program as a reference.

*In this code we take N and M as input where M is the number of terms
*to be printed of the N-bonacci series
*/
void N_bonacci(int n, int m) {

This comment has been minimized.

@Panquesito7

Panquesito7 Oct 21, 2020
Member

See the typical structure of a program or #962 as a reference.

@Swastyy
Copy link

@Swastyy Swastyy commented Jun 18, 2021

@neha-hasija17 hey! where did you find the problem statement?
Can you please tell me how can I share my solution?
(P.S. I am new to open source and need some initial help.)

@Panquesito7 Panquesito7 added this to List to Fix in Good First Issues Jun 18, 2021
@Panquesito7 Panquesito7 moved this from List to Fix to In Progress in Good First Issues Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Good First Issues
  
In Progress
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants