Skip to content

/ MISP

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate rows in MISP/app/Lib/Export/NidsExport.php / #6565

Open
zbyshak opened this issue Nov 9, 2020 · 1 comment
Open

duplicate rows in MISP/app/Lib/Export/NidsExport.php / #6565

zbyshak opened this issue Nov 9, 2020 · 1 comment
Labels
T: enhancement good first issue

Comments

@zbyshak
Copy link

@zbyshak zbyshak commented Nov 9, 2020

Problem in MISP/app/Lib/Export/NidsExport.php /
causes there are two rows in beggening of all rules regarding email. Bug is in row 161

case 'email':
$this->emailSrcRule($ruleFormat, $item['Attribute'], $sid);
$this->emailDstRule($ruleFormat, $item['Attribute'], $sid);
break;
this causes inserting both source and destination email at beggining of the file, then continues with the correct source / destination emails.
@PROTechThor
Copy link

@PROTechThor PROTechThor commented Nov 21, 2020

@Rafiot @iglocska Is this a duplicate that should be removed?

If yes, @zbyshak , would you be willing to make a quick PR towards this?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: enhancement good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@PROTechThor @zbyshak
You can’t perform that action at this time.