Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parallel testing #333

Closed
owenvoke opened this issue Feb 10, 2021 · 8 comments
Closed

Add support for parallel testing #333

owenvoke opened this issue Feb 10, 2021 · 8 comments
Labels
bug Good first issue help wanted

Comments

@owenvoke
Copy link
Member

@owenvoke owenvoke commented Feb 10, 2021

Foundation v8.27.0 added support for parallel testing in the test command. However, this is currently broken as per the notes in laravel-zero/foundation#52.

Preview of console error

The issue appears to be related to the use of $app['config'] in LaravelZero\Framework\Bootstrap\LoadConfiguration. I think this is because config() is a function/closure, so the app appears to try and instantiate this when checked with $this->isBuildable($concrete, $abstract) in the container resolution. 🤔

If we remove the Artisan::starting block the parallel testing works, however the actual application then has the wrong version and name.

On a side note, running Paratest directly using LARAVEL_PARALLEL_TESTING=1 ./vendor/bin/paratest works fine. 🤷🏻
@kzvonov
Copy link

@kzvonov kzvonov commented Sep 21, 2021

@owenvoke Hello 👋
Do you want --parallel flag working?
If the issue is still here, I think I can try to take this one.

@owenvoke
Copy link
Member Author

@owenvoke owenvoke commented Sep 21, 2021

@kzvonov, if you're able to work on this, that would be brilliant! Sorry I haven't really had time recently to work on Laravel Zero much unfortunately.

@kzvonov
Copy link

@kzvonov kzvonov commented Sep 21, 2021

@owenvoke yep, I will try to get into this today's evening or tomorrow.

Thanks for the trust)

@owenvoke
Copy link
Member Author

@owenvoke owenvoke commented Sep 21, 2021

Any issues, feel free to ping me in a comment. 👍🏻

@kzvonov
Copy link

@kzvonov kzvonov commented Sep 22, 2021 •
edited

@owenvoke Hello!
I've updated compose.json, and then --parallel works for me. The packages I've added are here https://github.com/Zvonov-Devs/laravel-zero/commit/19c4e604d47a45adf6b83240790ebcb02c01fae3

But as I understand the issue in laravel-zero/foundation with version 8.27.0. Am I right that I need to change my composer.lock file and then try with an older foundation? if the answer is yes then it's also working =>
Screenshot 2021-09-22 at 14 50 36
The same 👌 result I got when run with laravel-zero/foundation with version 8.26.0.

Did I miss something?

@owenvoke
Copy link
Member Author

@owenvoke owenvoke commented Sep 22, 2021

Hmm, that's weird... perhaps it's an issue on my local setup. 🤔 It seems to be working fine for me now too! That's great. 😬 I have no idea what the issue was then... And I guess this can be closed, thank you for testing!

@owenvoke owenvoke closed this Sep 22, 2021
@kzvonov
Copy link

@kzvonov kzvonov commented Sep 22, 2021

@owenvoke no problem) But can you give me another issue to work on?

@owenvoke
Copy link
Member Author

@owenvoke owenvoke commented Sep 23, 2021

@kzvonov, I think the main things are just:

  • Making sure Laravel Zero supports PHP 8.1, which I'm currently looking into
  • Going through any of the old issues in the issues tab and working through them

Personally this was the main issue I wanted to try and fix.
#343

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Good first issue help wanted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@owenvoke @kzvonov