Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame.copy not consolidating #42579

Merged
merged 6 commits into from Jul 23, 2021
Merged

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jul 16, 2021

  • closes #42477
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

@mzeitlin11 did you want to suggest an improved warning message for .insert?

@mzeitlin11
Copy link
Member

@mzeitlin11 mzeitlin11 commented Jul 16, 2021

@mzeitlin11 did you want to suggest an improved warning message for .insert?

Thanks for the heads up. Since this fix should be independent to that and don't want to hold up this pr, probably easiest as a separate pr

@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jul 19, 2021

@jbrockmendel tests are failing. also needs release note for 1.3.1

@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Jul 19, 2021

also needs release note for 1.3.1

bugfix section

@jreback
Copy link
Contributor

@jreback jreback commented Jul 20, 2021

hmm these failures unrelated? maybe merge master again

@jreback
Copy link
Contributor

@jreback jreback commented Jul 20, 2021

can you run some asv's as well to make sure this doesn't change perf drastically. maybe insert / concat / copy ones.

@jreback jreback merged commit 1b60699 into pandas-dev:master Jul 23, 2021
25 checks passed
@jreback
Copy link
Contributor

@jreback jreback commented Jul 23, 2021

@meeseeksdev backport 1.3.x

@meeseeksdev
Copy link

@meeseeksdev meeseeksdev bot commented Jul 23, 2021

Something went wrong ... Please have a look at my logs.

@jbrockmendel jbrockmendel deleted the regr-42477 branch Jul 23, 2021
simonjayhawkins pushed a commit that referenced this issue Jul 23, 2021
Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
CGe0516 added a commit to CGe0516/pandas that referenced this issue Jul 29, 2021
Joeperdefloep added a commit to Joeperdefloep/pandas that referenced this issue Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants