Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Try to speed up ArrayManager #42634

Merged
merged 3 commits into from Jul 25, 2021
Merged

CI: Try to speed up ArrayManager #42634

merged 3 commits into from Jul 25, 2021

Conversation

@lithomas1
Copy link
Member

@lithomas1 lithomas1 commented Jul 20, 2021

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

Don't re-run ArrayManager tests if we are already in ArrayManager mode.

P.S. I'm not sure what the arraymanager marker is supposed to be for. If it only runs the frame tests, wouldn't it be better to just specify that directly in the PYTEST_AM_CMD.

@lithomas1 lithomas1 marked this pull request as ready for review Jul 21, 2021
@lithomas1 lithomas1 requested a review from jorisvandenbossche Jul 21, 2021
@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jul 24, 2021

did this improve the CI time as intended?

@lithomas1
Copy link
Member Author

@lithomas1 lithomas1 commented Jul 25, 2021

Its around 2 min. or ~5% of time.

@jreback jreback added this to the 1.4 milestone Jul 25, 2021
@jreback jreback merged commit 7ad5460 into pandas-dev:master Jul 25, 2021
25 checks passed
25 checks passed
@github-actions
Checks
Details
@github-actions
Linux_py38_IO (ci/deps/actions-38-db-min.yaml)
Details
@github-actions
pytest (actions-38-minimum_versions.yaml, not slow and not network and not clipboard)
Details
@github-actions
actions-310-dev actions-310-dev
Details
@github-actions
pre-commit
Details
@github-actions
build (3.8)
Details
@github-actions
Linux_py38_IO (ci/deps/actions-38-db.yaml)
Details
@github-actions
pytest (actions-38-locale_slow.yaml, slow, language-pack-it xsel, it_IT.utf8, it_IT.utf8)
Details
@github-actions
build (3.9)
Details
@github-actions
pytest (actions-38.yaml, not slow and not network and not clipboard)
Details
@github-actions
pytest (actions-38-slow.yaml, slow)
Details
@github-actions
pytest (actions-38-locale.yaml, not slow and not network, language-pack-zh-hans xsel, zh_CN.utf8,...
Details
@github-actions
pytest (actions-39-slow.yaml, slow)
Details
@github-actions
pytest (actions-39-numpydev.yaml, not slow and not network, xsel, deprecate, -W error)
Details
@github-actions
pytest (actions-39.yaml, not slow and not network and not clipboard)
Details
@github-actions
Web and docs
Details
@github-actions
Test experimental data manager (not slow and not network and not clipboard)
Details
@github-actions
Test experimental data manager (slow)
Details
@codecov
codecov/patch Coverage not affected when comparing 46ed60a...e2d9249
Details
@codecov
codecov/project 93.21% (target 82.00%)
Details
@azure-pipelines
pandas-dev.pandas Build #20210721.2 succeeded
Details
@azure-pipelines
pandas-dev.pandas (Windows py38_np18) Windows py38_np18 succeeded
Details
@azure-pipelines
pandas-dev.pandas (Windows py39) Windows py39 succeeded
Details
@azure-pipelines
pandas-dev.pandas (macOS py38_macos) macOS py38_macos succeeded
Details
@azure-pipelines
pandas-dev.pandas (py38_32bit) py38_32bit succeeded
Details
@jreback
Copy link
Contributor

@jreback jreback commented Jul 25, 2021

ok this is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants