Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor preparePVCDataSourceForProvisioning to support BlockVolume tests in multivolume.go #102787

Open
mauriciopoppe opened this issue Jun 10, 2021 · 7 comments

Comments

@mauriciopoppe
Copy link
Member

@mauriciopoppe mauriciopoppe commented Jun 10, 2021

What would you like to be added:

In #102775 block volume tests were skipped because preparePVCDataSourceForProvisioning is not using utils.CheckWriteToPath / utils.CheckReadFromPath, there are more details about how these functions are used in TestConcurrentAccessToSingleVolume

This is a test that uses the XFS, if tested using the GCE PD storage class it should have fstype: xfs, in addition the test cluster should have the VolumeSnapshot CRDs and the controllers installed

/sig storage
/area testing
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jun 10, 2021

@mauriciopoppe:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

What would you like to be added:

In #102775 block volume tests were skipped because preparePVCDataSourceForProvisioning is not using utils.CheckWriteToPath / utils.CheckReadFromPath, there are more details about how these functions are used in TestConcurrentAccessToSingleVolume

/sig storage
/area testing
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jun 10, 2021

@mauriciopoppe: The label(s) area/testing cannot be applied, because the repository doesn't have them.

In response to this:

What would you like to be added:

In #102775 block volume tests were skipped because preparePVCDataSourceForProvisioning is not using utils.CheckWriteToPath / utils.CheckReadFromPath, there are more details about how these functions are used in TestConcurrentAccessToSingleVolume

/sig storage
/area testing
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Jun 10, 2021

@mauriciopoppe: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dbgoytia
Copy link

@dbgoytia dbgoytia commented Jun 10, 2021

Hey team! I'd like to further investigate on this issue if possible?

@dbgoytia
Copy link

@dbgoytia dbgoytia commented Jun 10, 2021

/assign

@mauriciopoppe
Copy link
Member Author

@mauriciopoppe mauriciopoppe commented Jun 11, 2021

/area test

hey @dbgoytia, sure, I've added more info about how to test it, it requires these components:

@dbgoytia
Copy link

@dbgoytia dbgoytia commented Jun 11, 2021

thanks a lot @mauriciopoppe !! I might be a bit slow though, I'm pretty new to the community. I appreciate the documentation you shared, the assignation and how to replicate it, I'll test it out and if I have some doubts, I'll get back with you :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants