master
Commits on Sep 24, 2021
-
ci: correctly handle commit message with carriage returns in `payload…
…-size.sh` (#43569) Previously, if a commit message contained a carriage return in its header, the `payload-size.sh` script would fail to upload the payload size data to Firebase, because the JSON payload would be messed up when trying to concatenate the commit message headers. See an example [here][1]. This commit avoids this problem by replacing carriage returns before concatenating the commit message headers with the JSON payload string. [1]: https://app.circleci.com/pipelines/github/angular/angular/37437/workflows/d0fa4adf-43bb-464e-a2fd-d87da15226dd PR Close #43569
-
fix(docs-infra): display deprecation notes for properties (#43566)
Previously, deprecation notes for deprecated class/interface properties were not shown in the API docs. This commit fixes it by ensuring that deprecation notes are shown for properites (similar to how it works for methods). PR Close #43566
-
fix(service-worker): do not unassign clients from a broken version (#…
…43518) Previously, when a version was found to be broken, any clients assigned to that version were unassigned (and either assigned to the latest version or to none if the latest version was the broken one). A version could be considered broken for several reasons, but most often it is a response for a hashed asset that eiher does not exist or contains different content than the SW expects. See #28114 (comment) for more details. However, assigning a client to a different version (or the network) in the middle of a session, turned out to be more risky than keeping it on the same version. For angular.io, for example, it has led to #28114. This commit avoids making things worse when identifying a broken version by keeping existing clients to their assigned version (but ensuring that no new clients are assigned to the broken version). NOTE: Reloading the page generates a new client ID, so it is like a new client for the SW, even if the tab and URL are the same. PR Close #43518
-
test(service-worker): use correct assertion in tests (#43518)
Previously, a ServiceWorker test was using the `MockServerState#sawRequestFor()` method. This method, however, only returns a boolean indicating whether a request had been seen, but would not throw an error in either case. Since the intention was to assert that a specific request was made, this commit switches to the correct `MockServerState#assertSawRequestFor()` method. PR Close #43518
-
docs: reviewed tag added (#43472)
PR Close #43472
-
docs: review tag added (#43469)
PR Close #43469
-
test: update localize-extract source paths (#43417)
As a result of dropping differential loading, In version 13 the Angular CLI no longer generates files prefixed with the ECMA version. PR Close #43417
-
test: update integration payload size checks golden file (#43417)
With this change we update the integration payload size checks golden file to reflect the file names in version 13. Some considering about the increased in file sizes - The increase in runtime is caused by inrtroduction of Trusted Types in CLI 12.1 which causes addition bytes to be included in the file - Other increase/decreases are caused by changes of the minifier. Since the CLI now uses ESbuild as primary minifier instead of terser. PR Close #43417
-
test: update browserslist configuration to replace Angular CLI projec…
…ts (#43417) With this change we update various browserslist configuration file to match newly generated projects. https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/application/files/.browserslistrc.template PR Close #43417
-
feat(forms): allow disabling min/max validators dynamically (by setti…
…ng the value to `null`) (#42978) This commit updates the logic of the `min` and `max` validators to allow disabling them dynamically in case `null` is provided as a value. For example: `<input type="number" [min]="minValue">`, when `minValue` might be set to `null` in a component class. This should allow `min` and `max` validators to be used for dynamic forms. Note: similar support was added to the `minLength` and `maxLength` validators earlier (see #42565). PR Close #42978
Commits on Sep 23, 2021
-
docs: update review date (#43245)
docs: Update review date for last content update. PR Close #43245
-
docs: add subtopics for internationalization (#43245)
Add subtopics for internationalization guide. PR Close #43245
-
Update content per review. PR Close #43245
-
docs: update punctuation (#43245)
Update punctuation per review. Co-authored-by: TeriGlover <teriglover@google.com> PR Close #43245
-
Update content per review. Co-authored-by: TeriGlover <teriglover@google.com> PR Close #43245
-
Update link per review. PR Close #43245
-
Update content per review. PR Close #43245
-
docs: update punctuation (#43245)
Update punctuation per review. Co-authored-by: TeriGlover <teriglover@google.com> PR Close #43245
-
Update grammar per review. Co-authored-by: TeriGlover <teriglover@google.com> PR Close #43245
-
Update content per review. PR Close #43245
-
docs: update spelling (#43245)
Update spelling per review. Co-authored-by: TeriGlover <teriglover@google.com> PR Close #43245
-
docs: add new internationalization links (#43245)
Update link for subtopics of internationalization guide. PR Close #43245
-
docs: add new internationalization links (#43245)
Update link for subtopics of internationalization guide. Clean up markdown. PR Close #43245
-
docs: add subtopics for internationalization to PR (#43245)
Add subtopics for internationalization guide to PR. PR Close #43245
-
docs: add redirect for internationalization (#43245)
Add redirect for internationalization guide. Add test for redirect. PR Close #43245
-
docs: add subtopics for internationalization to toc (#43245)
Add subtopics for internationalization guide to toc. PR Close #43245
-
docs: add subtopics for internationalization (#43245)
Add subtopics for internationalization guide. PR Close #43245
-
feat(core): support TypeScript 4.4 (#43281)
Adds support for TypeScript 4.4. High-level overview of the changes made in this PR: * Bumps the various packages to `typescript@4.4.2` and `tslib@2.3.0`. * The `useUnknownInCatchVariables` compiler option has been disabled so that we don't have to cast error objects explicitly everywhere. * TS now passes in a third argument to the `__spreadArray` call inside child class constructors. I had to update a couple of places in the runtime and ngcc to be able to pick up the calls correctly. * TS now generates code like `(0, foo)(arg1, arg2)` for imported function calls. I had to update a few of our tests to account for it. See microsoft/TypeScript#44624. * Our `ngtsc` test setup calls the private `matchFiles` function from TS. I had to update our usage, because a new parameter was added. * There was one place where we were setting the readonly `hasTrailingComma` property. I updated the usage to pass in the value when constructing the object instead. * Some browser types were updated which meant that I had to resolve some trivial type errors. * The downlevel decorators tranform was running into an issue where the Closure synthetic comments were being emitted twice. I've worked around it by recreating the class declaration node instead of cloning it. PR Close #43281
-