Skip to content

/ NativeScript Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: combine prettier with eslint #9348

Merged
merged 1 commit into from Apr 27, 2021
Merged

chore: combine prettier with eslint #9348

merged 1 commit into from Apr 27, 2021

Conversation

@farfromrefug
Copy link
Collaborator

@farfromrefug farfromrefug commented Apr 20, 2021

This simply plugs eslint and prettier together. That way when you lint with eslint it also fixes indentations and such
@farfromrefug
chore: combine prettier with eslint
e8738c7
@cla-bot cla-bot bot added the cla: yes label Apr 20, 2021
@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Apr 20, 2021

We'll do a nx migrate latest first before merging as Nx 12 did provide full eslint migrations and can mesh this up against those.

@NathanWalker NathanWalker changed the base branch from master to feat/eslint-improvements Apr 27, 2021
@NathanWalker NathanWalker merged commit 8f68a6f into NativeScript:feat/eslint-improvements Apr 27, 2021
3 of 4 checks passed
NathanWalker added a commit that referenced this issue Apr 27, 2021
@farfromrefug @NathanWalker
chore: combine prettier with eslint (#9348)
445b294
@NathanWalker NathanWalker mentioned this pull request Apr 27, 2021
Merged
@farfromrefug farfromrefug deleted the eslint_prettier branch Apr 27, 2021
NathanWalker added a commit that referenced this issue May 2, 2021
@farfromrefug @NathanWalker
chore: combine prettier with eslint (#9348) (#9360)
0d4ccba 
Co-authored-by: Martin Guillon <martin.guillon@akylas.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@farfromrefug @NathanWalker